Bluetooth: GATT: Auto init if bt_gatt_service_register is called #9848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9848 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 213 213
Lines 25964 25964
Branches 5598 5598
=======================================
Hits 13576 13576
Misses 10150 10150
Partials 2238 2238Continue to review full report at Codecov.
|
lemrey
approved these changes
Sep 7, 2018
carlescufi
approved these changes
Sep 7, 2018
jhedberg
approved these changes
Sep 10, 2018
nashif
reviewed
Sep 10, 2018
subsys/bluetooth/host/gatt.c
Outdated
| @@ -237,6 +238,9 @@ static void sc_process(struct k_work *work) | |||
|
|
|||
| void bt_gatt_init(void) | |||
| { | |||
| if (!atomic_cas(&init, 0, 1)) | |||
There was a problem hiding this comment.
curly braces for this if statement...
This ensures the core services are always registered first and the gatt_sc work is initialized. Fixes zephyrproject-rtos#9785 Signed-off-by: Luiz Augusto von Dentz <[email protected]> Signed-off-by: Anas Nashif <[email protected]>
nashif
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the core services are always registered first and the
gatt_sc work is initialized.
Fixes #9785
Signed-off-by: Luiz Augusto von Dentz [email protected]