drv: ft8xx: new coprocessor commands #82376
Open
+470
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ft8xx driver reported a compile-time error caused by an invalid logging configuration of this module. This patch intorduces FT800-specific logging configuration in Kconfig that is used by the driver. This way the error is fixed. Signed-off-by: Hubert Miś <[email protected]>
kartben
reviewed
Dec 1, 2024
hubertmis
force-pushed
the
pr/ft8xx-update
branch
2 times, most recently
from
c69adb6
to
56cab5d
Compare
Implement more co-processor commands in the FT8xx display driver. The list of the new implemented commands consists of: * CMD_FGCOLOR * CMD_BGCOLOR * CMD_SLIDER * CMD_TOGGLE * CMD_TRACK Signed-off-by: Hubert Miś <[email protected]>
hubertmis
force-pushed
the
pr/ft8xx-update
branch
from
56cab5d
to
6837dda
Compare
jilaypandya
reviewed
Dec 1, 2024
| @@ -73,6 +78,183 @@ void ft8xx_copro_cmd_swap(void) | |||
| ft8xx_copro_cmd(CMD_SWAP); | |||
| } | |||
|
|
|||
| void ft8xx_copro_cmd_fgcolor(uint32_t c) | |||
There was a problem hiding this comment.
is c for color ? would use the full term :)
| const uint16_t cmd_size = sizeof(CMD_FGCOLOR) + | ||
| sizeof(c); | ||
|
|
||
| while (ram_cmd_freespace() < cmd_size) { |
There was a problem hiding this comment.
Is this function a blocking call? Probably it should be refelected in documentation as well :) same goes for other functions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement more co-processor commands in the FT8xx display driver. The list of the new implemented commands consists of: