tests: arm: remove GNUC ifdef #82348
Open
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to get compile error rather than #error Signed-off-by: Robin Kastberg <[email protected]>
zephyrbot
requested review from
bbolen,
carlocaione,
galak,
ithinuel,
MaureenHelm,
microbuilder and
stephanosio
tejlmand
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
lgtm.
If we want to increase support for more toolchains in Zephyr then avoiding GNUC checks in test code like this seems a logical step.
Long term we can consider a Zephyr specific flag which the Zephyr toolchain integration can set for test compatible checks, but such future work should not block this PR.
stephanosio
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting zephyr to IAR I stumbled onto this test.
I think these ifdefs are guarding the inline assembly in this test.
But it is better to get compile error rather than #error. (We can handle this inline assembly almost just fine)
Does this actually happen to any other toolchain?
Maybe this test should filter on CONFIG_TOOLCHAIN_HAS_GNU_EXTENSIONS or similar instead?