Deprecating stream_flash_erase_page #82326
Draft
+84
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches flash_sync to use stream_flash_erase_to_append instead of stream_flash_erase_page in preparation of deprecating the later and reming control on erase from API user. Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
fix-for-67407
branch
from
0e91e12
to
b767466
Compare
Keep on testing the function but fix logic where applicable and remove last_erased_page_start_offset which has been replaced with erased_up_to in stream_flash_ctx. Signed-off-by: Dominik Ermel <[email protected]>
The commit marks stream_flash_erase_page as deprecated. After the function is removed users will have to rely on stream flash to erase space it needs prior to write. The stream_flash_erase_page has several issues like using non-relative offset for erases, allowing to destroy data already written or even erase out of area available for stream flash. This fixes zephyrproject-rtos#67407 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
fix-for-67407
branch
from
b767466
to
97dea62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few commits that