Driver: hci_nxp_setup: Support HCI baudrate update #82308
+80
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lylezhu2012
requested review from
mmahadevan108,
dleach02,
alwa-nordic,
jhedberg and
Vudentz
as code owners
zephyrbot
added
area: Bluetooth
area: Bluetooth HCI
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
hermabe,
HoZHel,
manuargue,
MarkWangChinese,
sjanc,
Thalley and
theob-pro
jhedberg
reviewed
Nov 29, 2024
Comment on lines
20
to
25
| hci-operation-speed: | ||
| hci-default-speed: | ||
| type: int | ||
| description: | | ||
| HCI UART baudrate for feature operation. If not defined | ||
| HCI UART default baudrate after the FW download. If not defined | ||
| bus/current-speed will be used as default. | ||
|
|
||
| hci-operation-speed: | ||
| type: int | ||
| description: | | ||
| HCI UART running baudrate for feature operation. If not defined | ||
| hci-default-speed will be used as default. | ||
| When hci-operation-speed is different with hci-default-speed, | ||
| the HCI UART baudrate update process will be involved to change | ||
| the HCI UART baudrate from hci-default-speed to | ||
| hci-operation-speed. | ||
|
|
There was a problem hiding this comment.
I have a few questions about these.
- If these are specific to this driver, then shouldn't you prefix them with
nxp,(or possibly withzephyr,as per https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#the-zephyr-prefix)? - Does there perhaps exist some existing properties elsewhere with the same semantics, if so, consider reusing those instead of defining new ones.
- Since the HCI node will be a child node of a UART device, could you derive some information of the baud rate from the UART node instead?
There was a problem hiding this comment.
- If these are specific to this driver, then shouldn't you prefix them with
nxp,(or possibly withzephyr,as per https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#the-zephyr-prefix)?
It is a member of [nxp,bt-hci-uart.yaml](https://github.com/zephyrproject-rtos/zephyr/pull/82308/files#diff-1d64be33434b758bd8cc34a07c9a3d770c1f393fbf681ec1fb8914ab44f95ad8). And I do not think it is not a member defined by zephyr. But I did not notice it should be prefixed with nxp,. Since it is a member of nxp,bt-hci-uart.yaml. And file nxp,bt-hci-uart.yaml has been prefixed with nxp, is it necessary to add a prefix to each member of nxp,bt-hci-uart.yaml?
- Does there perhaps exist some existing properties elsewhere with the same semantics, if so, consider reusing those instead of defining new ones.
Yes. current-speed of UART can be used to achieve the purpose. I have remove the changes of hci-default-speed from this PR.
- Since the HCI node will be a child node of a UART device, could you derive some information of the baud rate from the UART node instead?
Yes. current-speed is used as the default bandrate for HCI.
Change running baudrate from `115200` from `3000000`. Implement the function `bt_h4_vnd_setup` to update the HCI bandrate. Add Kconfig `BT_H4_NXP_CTLR_WAIT_TIME_AFTER_BAUDRATE_UPDATE` to set the waiting time after the controller bandrate HCI vendor specific command sent. It is used to ensure the controller is ready to update HCI bandrate. Select `BT_HCI_SETUP` if `BT_H4_NXP_CTLR` is enabled. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
update_hci_baudrate
branch
from
092efce
to
773755f
Compare
jhedberg
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
hci-default-speedto set default HCI bandrate after the firmware download. Andhci-operation-speedis used to set the running HCI bandrate.Change running baudrate from
115200from3000000.Implement the function
bt_h4_vnd_setupto update the HCI bandrate.Add Kconfig
BT_H4_NXP_CTLR_WAIT_TIME_AFTER_BAUDRATE_UPDATEto set the waiting time after the controller bandrate HCI vendor specific command sent. It is used to ensure the controller is ready to update HCI bandrate.Select
BT_HCI_SETUPifBT_H4_NXP_CTLRis enabled.