Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: net: cellular_modem: Add additional overlay for nrf7002dk #81724

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethansisk
Copy link

This overlay is for the nrf7002dk. The modem tested was the Telit ME310G1-WW, but should work for any of the supported modems provided that the UART lines are defined and hooked up correctly.

This overlay is for the nrf7002dk. The modem tested was the Telit ME310G1-WW,
but should work for any of the supported modems provided that the UART lines
are defined and hooked up correctly.

Signed-off-by: Ethan Sisk <[email protected]>
Copy link

Hello @ethansisk, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@bjarki-andreasen
Copy link
Collaborator

For local board modifications, one should use snippets locally. Local board modifications can't go upstream since overlays apply to the base board, so the overlay would be applied, likely incorrectly, to everyone elses local board, which could be configured very differently :)

To run the cellular sample with snippets, you would create the snippet with the overlay you add in this PR (named "nrf7002dk_telit" in this example), then build the sample like

west build -p -b nrf7002dk/nrf5340/cpuapp --snippet nrf7002dk_telit zephyr/samples/net/cellular_modem

With the base board and snippet, you have a "custom" local board you use for any in-tree sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants