twister: add trace print in exception #81703
Open
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
gchwier,
golowanow,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
|
pre discussion in #80623 |
hakehuang
force-pushed
the
twister_add_callstack_print
branch
2 times, most recently
from
9a01921
to
e778ea7
Compare
|
@nashif , @gchwier , @golowanow , @PerMac , @LukaszMrugala , @KamilxPaszkiet please review this. |
golowanow
reviewed
Nov 26, 2024
Comment on lines
14
to
16
| for line in traceback.format_stack(): | ||
| logger.info(line.strip()) | ||
| logger.warning("======call stack dump end============") |
There was a problem hiding this comment.
This way it will log the trace stack at once to reduce chances of other output in between, and to omit its last lines from TwisterException code itself.
Suggested change
| for line in traceback.format_stack(): | |
| logger.info(line.strip()) | |
| logger.warning("======call stack dump end============") | |
| logger.error(''.join(["Twister call stack dump:\n"] + traceback.format_stack()[:-1])) |
add trace print when exception happens Signed-off-by: Hake Huang <[email protected]>
update test cases for twister 1. test_errors.py add protection. 2. test_handlers.py change call to status 3. test_testsuite.py change call to status The log traces for TwisterException objects only. And the stack trace output follow the same rules for all exceptions, but StatusAttributeError with its dedicated handlers. Signed-off-by: Hake Huang <[email protected]>
hakehuang
force-pushed
the
twister_add_callstack_print
branch
from
e778ea7
to
ac3cd20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add trace print when exception happens