Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: winc1500: Driver fixes #80897

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

icsys-aal
Copy link
Contributor

We're using the WINC1500 driver in an application where we want our board to be an access point. This has exposed several issues with the current WINC1500 driver, which this PR tries to fix.

Note that we haven't tested client mode with these changes.

jukkar
jukkar previously approved these changes Nov 6, 2024
Kludentwo
Kludentwo previously approved these changes Nov 6, 2024
@icsys-aal icsys-aal dismissed stale reviews from Kludentwo and jukkar via fb26007 November 6, 2024 11:04
@icsys-aal icsys-aal force-pushed the winc1500 branch 2 times, most recently from fb26007 to 35f213e Compare November 7, 2024 08:36
…set.

The "nm_bsp_reset" is used to apply a hard reset to the WINC board by
setting CHIP_EN and RESET_N signals low,then after specific delay
the function will put CHIP_EN high then RESET_N high.
reset-gpio is however defined as active low , causing this function
to hold the wifi module in reset.

Signed-off-by: Andreas Ålgård <[email protected]>
When we accept a message the context state should be set to connected

Signed-off-by: Andreas Ålgård <[email protected]>
Renamed socket functions to avoid multiple definitions in the HAL library

Signed-off-by: Andreas Ålgård <[email protected]>
@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 12, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_atmel zephyrproject-rtos/hal_atmel@56d60eb zephyrproject-rtos/hal_atmel#42 zephyrproject-rtos/hal_atmel#42/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

west.yml Outdated Show resolved Hide resolved
Needed for the winc1500 driver in hal_atmel to be compatible with
 POSIX enabled.

Signed-off-by: Andreas Ålgård <[email protected]>
@nandojve
Copy link
Member

Hi @icsys-aal ,

Note that we haven't tested client mode with these changes.

Changes LGTM but we need to tests with https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/net/wifi/apsta_mode sample. Could you check this?

@icsys-aal
Copy link
Contributor Author

Hi @icsys-aal ,

Note that we haven't tested client mode with these changes.

Changes LGTM but we need to tests with https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/net/wifi/apsta_mode sample. Could you check this?

I tried to test this, but failed as the dhcpv4 server init function failed, which I suspect is because WINC1500 has its own DHCP server when it is in AP mode.
I see this sample is very new, has this sample ever passed for WINC1500?
At first glance it looks like this sample is made for ESP32 to me.

@jukkar
Copy link
Member

jukkar commented Nov 21, 2024

At first glance it looks like this sample is made for ESP32 to me.

That is correct, it was relocated from esp32 driver sample by commit d75b210

@nandojve
Copy link
Member

Hi @jukkar ,

It has been sometime I'm not looking this area.
Is samples/net/wifi/shell the old samples/net/wifi ?

My expectation is that at least the shield could work as mentioned here https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/shields/adafruit_winc1500/doc/index.rst

@jukkar
Copy link
Member

jukkar commented Nov 23, 2024

Is samples/net/wifi/shell the old samples/net/wifi ?

Yes, that is correct.

@nandojve
Copy link
Member

Hi @jukkar ,

Is samples/net/wifi/shell the old samples/net/wifi ?

Yes, that is correct.

Thank you for clarify : )

@icsys-aal ,

Sorry for my confusion with the wrong sample. In the past the driver seems to worked with the samples/net/wifi/shell. Could you check https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/shields/adafruit_winc1500/doc/index.rst and see if we can have a valid config ?

I would like understand how are you testing the WINC1500. Is there any application in tree that I can reproduce ? What is the configuration ?

My intention is detect any problem with the recent version of this driver in Zephyr and have an issue that point this. It is very valuable your input here since you know how it works. If you can report here I'll rely appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Wi-Fi Wi-Fi DNM This PR should not be merged (Do Not Merge) manifest manifest-bsim manifest-hal_atmel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants