tests: Bluetooth: Audio: Remove uses of K_FOREVER in syswg for TX #80691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
from
8107b66
to
2df922c
Compare
This was referenced Nov 1, 2024
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
from
2df922c
to
ee52081
Compare
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
2 times, most recently
from
c653fb7
to
ab69d4d
Compare
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
from
ab69d4d
to
0f74ed0
Compare
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
4 times, most recently
from
42f79c9
to
b8e1ff9
Compare
rruuaanng
reviewed
Nov 20, 2024
| * | ||
| * @retval true if it has been configured for TX, and false if not | ||
| */ | ||
| bool stream_tx_can_send(const struct bt_bap_stream *stream); |
There was a problem hiding this comment.
Why is it can_send, not is_send or is_conf_send.
There was a problem hiding this comment.
To follow the stream_tx prefit it sounds weird to have stream_tx_is_send or stream_tx_is_conf_send as stream_tx refers to the module, and not the stream
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
3 times, most recently
from
33f39e6
to
48528a2
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben and
kruithofa
zephyrbot
requested review from
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
Several tests were using K_FOREVER when allocating the buffer for TX in the system workqueue, which is illegal behavior. The solution chosen was to create a TX thread to handle TX, similar to the solution used in the audio shell and some sample applications. This way we can continue to use K_FOREVER when allocting buffers and it will always be done in a round-robin fashion while TXing as much as possible, by always enqueuing all the buffers with mock data. Since this works for all streams (both broadcast and unicast), it was obvious to use the same implementation for all tests, and thus cleaning up the tests a bit and more them more similar. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_bsim_tx_fix
branch
from
48528a2
to
975c37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests were using K_FOREVER when allocating the buffer for TX in the system workqueue, which is illegal behavior.
The solution chosen was to create a TX thread to handle TX, similar to the solution used in the audio shell and some sample applications.
This way we can continue to use K_FOREVER when allocting buffers and it will always be done in a round-robin fashion while TXing as much as possible, by always enqueuing all the buffers with mock data.
Since this works for all streams (both broadcast and unicast), it was obvious to use the same implementation for all tests, and thus cleaning up the tests a bit and more them more similar.
fixes #80682