Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: disable shell for i.MX8QM and i.MX8QXP #79428

Conversation

iuliana-prodan
Copy link
Collaborator

Disable shell for i.MX8QM and i.MX8QXP since is not supported now.

@zephyrbot zephyrbot added area: Samples Samples area: IPC Inter-Process Communication area: Open AMP size: XS A PR changing only a single line of code labels Oct 4, 2024
@arnopo
Copy link
Collaborator

arnopo commented Oct 4, 2024

Are you sure that the shell is not working?
I would expect that it is generic as the console is over rpmsg (CONFIG_SHELL_BACKEND_RPMSG=y).
with that the console should be accessible from your board Linux console

To check it:
In your board Linux console check that you have a "/dev/ttyRPMSG1"
then

:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

@iuliana-prodan
Copy link
Collaborator Author

iuliana-prodan commented Oct 4, 2024

Are you sure that the shell is not working? I would expect that it is generic as the console is over rpmsg (CONFIG_SHELL_BACKEND_RPMSG=y). with that the console should be accessible from your board Linux console

To check it: In your board Linux console check that you have a "/dev/ttyRPMSG1" then

:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

With the shell config the communication between cores is broken (the first message sent from Linux get's stuck) because it messes up with the interrupts - for these 2 targets the UART has interrupts enabled.

The SHELL was enabled for all targets, in prj.conf and I don't think this should be for all targets, I'm pretty sure was not tested on all supported boards. IMO should be set per board.

LE: I don't have time to debug this issue now, that's why I prefer to disable the SHELL for i.MX8QM and i.MX8QXP, for now.
I'll get back to it, when time allows.

@arnopo
Copy link
Collaborator

arnopo commented Oct 7, 2024

on between cores is broken (the first message sen

@arnopo arnopo closed this Oct 7, 2024
@arnopo
Copy link
Collaborator

arnopo commented Oct 7, 2024

Are you sure that the shell is not working? I would expect that it is generic as the console is over rpmsg (CONFIG_SHELL_BACKEND_RPMSG=y). with that the console should be accessible from your board Linux console
To check it: In your board Linux console check that you have a "/dev/ttyRPMSG1" then

:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

With the shell config the communication between cores is broken (the first message sent from Linux get's stuck) because it messes up with the interrupts - for these 2 targets the UART has interrupts enabled.

The SHELL was enabled for all targets, in prj.conf and I don't think this should be for all targets, I'm pretty sure was not tested on all supported boards. IMO should be set per board.

LE: I don't have time to debug this issue now, that's why I prefer to disable the SHELL for i.MX8QM and i.MX8QXP, for now. I'll get back to it, when time allows.

Thanks for the clarification.
I'm not familiar with Zephyr process in such case, I let @doki-nordic and/or @carlocaione give advice on this (issue creation, commit message explaining more in detail limitation...)

@arnopo arnopo reopened this Oct 7, 2024
@arnopo
Copy link
Collaborator

arnopo commented Oct 7, 2024

Sorry, I had closed it by mistake...

Disable shell for i.MX8QM and i.MX8QXP since is not supported now.

Signed-off-by: Iuliana Prodan <[email protected]>
@iuliana-prodan iuliana-prodan force-pushed the disable_shell_on_8qm_and_8xp_for_openAMP_sample branch from b9beb3c to f6559e3 Compare October 9, 2024 14:04
@iuliana-prodan
Copy link
Collaborator Author

@doki-nordic @carlocaione @arnopo can you, please, take a look?
Thanks!

Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to me reasonable to have this patch as workaround.
The issue #79970 has been entered to address the point

@carlescufi carlescufi merged commit 4b16071 into zephyrproject-rtos:main Oct 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: IPC Inter-Process Communication area: Open AMP area: Samples Samples size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants