Introduce reworked API for ADC drivers

arch/arc/soc/quark_se_c1000_ss/Kconfig.defconfig

@@ -126,10 +126,8 @@ endif
 endif # I2C
 
 if ADC
-config ADC_QMSI_SS
+config ADC_DW
 	def_bool y
-config ADC_0_IRQ_PRI
-	default 0
 endif
 
 if BT_H4

arch/arc/soc/quark_se_c1000_ss/dts.fixup

@@ -68,4 +68,10 @@
 #define CONFIG_GPIO_QMSI_1_IRQ		INTEL_QMSI_GPIO_B0800B00_IRQ_0
 #define CONFIG_GPIO_QMSI_1_IRQ_PRI	INTEL_QMSI_GPIO_B0800B00_IRQ_0_PRIORITY
 
+#define CONFIG_ADC_0_IRQ		SNPS_DW_ADC_80015000_IRQ_NORMAL
+#define CONFIG_ADC_IRQ_ERR		SNPS_DW_ADC_80015000_IRQ_ERROR
+#define CONFIG_ADC_0_IRQ_PRI		SNPS_DW_ADC_80015000_IRQ_0_PRIORITY
+#define CONFIG_ADC_0_NAME		SNPS_DW_ADC_80015000_LABEL
+#define CONFIG_ADC_0_BASE_ADDRESS	SNPS_DW_ADC_80015000_BASE_ADDRESS
+
 /* End of SoC Level DTS fixup file */

arch/arm/soc/atmel_sam/same70/dts.fixup

@@ -95,10 +95,12 @@
 #define CONFIG_ADC_0_IRQ	ATMEL_SAM_AFEC_4003C000_IRQ_0
 #define CONFIG_ADC_0_IRQ_PRI	ATMEL_SAM_AFEC_4003C000_IRQ_0_PRIORITY
 #define CONFIG_ADC_0_NAME	ATMEL_SAM_AFEC_4003C000_LABEL
+#define CONFIG_ADC_0_PERIPHERAL_ID	ATMEL_SAM_AFEC_4003C000_PERIPHERAL_ID
 
 #define CONFIG_ADC_1_BASE_ADDRESS	ATMEL_SAM_AFEC_40064000_BASE_ADDRESS
 #define CONFIG_ADC_1_IRQ	ATMEL_SAM_AFEC_40064000_IRQ_0
 #define CONFIG_ADC_1_IRQ_PRI	ATMEL_SAM_AFEC_40064000_IRQ_0_PRIORITY
 #define CONFIG_ADC_1_NAME	ATMEL_SAM_AFEC_40064000_LABEL
+#define CONFIG_ADC_1_PERIPHERAL_ID	ATMEL_SAM_AFEC_40064000_PERIPHERAL_ID
 
 /* End of SoC Level DTS fixup file */

arch/arm/soc/nordic_nrf/nrf51/dts.fixup

@@ -1,6 +1,11 @@
 /* SoC level DTS fixup file */
 
 #define CONFIG_NUM_IRQ_PRIO_BITS	ARM_V6M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS
+
+#define CONFIG_ADC_0_IRQ		NORDIC_NRF_ADC_40007000_IRQ_0
+#define CONFIG_ADC_0_IRQ_PRI		NORDIC_NRF_ADC_40007000_IRQ_0_PRIORITY
+#define CONFIG_ADC_0_NAME		NORDIC_NRF_ADC_40007000_LABEL
+
 #define CONFIG_UART_0_BASE		NORDIC_NRF_UART_40002000_BASE_ADDRESS
 #define CONFIG_UART_0_IRQ_PRI		NORDIC_NRF_UART_40002000_IRQ_0_PRIORITY
 #define CONFIG_UART_0_IRQ_NUM		NORDIC_NRF_UART_40002000_IRQ_0

arch/arm/soc/nordic_nrf/nrf52/dts.fixup

@@ -1,6 +1,11 @@
 /* SoC level DTS fixup file */
 
 #define CONFIG_NUM_IRQ_PRIO_BITS	ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS
+
+#define CONFIG_ADC_0_IRQ		NORDIC_NRF_SAADC_40007000_IRQ_0
+#define CONFIG_ADC_0_IRQ_PRI		NORDIC_NRF_SAADC_40007000_IRQ_0_PRIORITY
+#define CONFIG_ADC_0_NAME		NORDIC_NRF_SAADC_40007000_LABEL
+
 #if defined(NORDIC_NRF_UARTE_40002000_BASE_ADDRESS)
 #define CONFIG_UART_0_BASE		NORDIC_NRF_UARTE_40002000_BASE_ADDRESS
 #define CONFIG_UART_0_IRQ_PRI		NORDIC_NRF_UARTE_40002000_IRQ_0_PRIORITY

boards/arc/arduino_101_sss/arduino_101_sss.dts

@@ -44,3 +44,7 @@
 &i2c3 {
 	status = "ok";
 };
+
+&adc0 {
+	status = "ok";
+};

boards/arc/quark_se_c1000_ss_devboard/quark_se_c1000_ss_devboard.dts

@@ -44,3 +44,7 @@
 &i2c3 {
 	status = "ok";
 };
+
+&adc0 {
+	status = "ok";
+};

boards/arm/nrf51_pca10028/nrf51_pca10028.dts

@@ -30,6 +30,10 @@
 	status ="ok";
 };
 
+&adc {
+	status ="ok";
+};
+
 &uart0 {
 	current-speed = <115200>;
 	status = "ok";

boards/arm/nrf51_pca10028/nrf51_pca10028.yaml

@@ -7,5 +7,6 @@ toolchain:
   - gnuarmemb
 ram: 32
 supported:
+  - adc
   - ble
   - nvs

boards/arm/nrf52810_pca10040/nrf52810_pca10040.dts

@@ -66,6 +66,10 @@
 	};
 };
 
+&adc {
+	status = "ok";
+};
+
 &gpiote {
 	status ="ok";
 };

boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts

@@ -22,6 +22,10 @@
 	};
 };
 
+&adc {
+	status ="ok";
+};
+
 &gpiote {
 	status ="ok";
 };

boards/arm/nrf52840_pca10056/nrf52840_pca10056.yaml

@@ -6,6 +6,7 @@ toolchain:
   - zephyr
   - gnuarmemb
 supported:
+  - adc
   - usb_device
   - ble
   - ieee802154

boards/arm/nrf52_pca10040/nrf52_pca10040.dts

@@ -23,6 +23,10 @@
 	};
 };
 
+&adc {
+	status ="ok";
+};
+
 &gpiote {
 	status ="ok";
 };

boards/arm/nrf52_pca10040/nrf52_pca10040.yaml

@@ -8,4 +8,5 @@ toolchain:
 ram: 64
 flash: 512
 supported:
+  - adc
   - nvs

boards/arm/nrf52_pca20020/nrf52_pca20020.dts

@@ -21,6 +21,10 @@
 	};
 };
 
+&adc {
+	status = "ok";
+};
+
 &gpiote {
 	status = "ok";
 };

boards/arm/sam_e70_xplained/doc/sam_e70_xplained.rst

@@ -56,6 +56,8 @@ features:
 +-----------+------------+-------------------------------------+
 | GPIO      | on-chip    | gpio                                |
 +-----------+------------+-------------------------------------+
+| ADC       | on-chip    | ADC via AFEC                        |
++-----------+------------+-------------------------------------+
 
 Other hardware features are not currently supported by Zephyr.
 

boards/arm/sam_e70_xplained/sam_e70_xplained.yaml

@@ -7,3 +7,4 @@ toolchain:
   - gnuarmemb
 supported:
   - netif:eth
+  - adc

boards/x86/quark_d2000_crb/quark_d2000_crb.yaml

@@ -9,7 +9,6 @@ toolchain:
 ram: 8
 flash: 32
 supported:
-  - adc
   - i2c
   - spi
   - gpio

drivers/adc/CMakeLists.txt

@@ -1,10 +1,9 @@
 zephyr_library()
 
-zephyr_library_sources_ifdef(CONFIG_ADC_DW            adc_dw.c)
-zephyr_library_sources_ifdef(CONFIG_ADC_MCUX_ADC16 	  adc_mcux_adc16.c)
-zephyr_library_sources_ifdef(CONFIG_ADC_QMSI   		  adc_qmsi.c)
-zephyr_library_sources_ifdef(CONFIG_ADC_QMSI_SS		  adc_qmsi_ss.c)
-zephyr_library_sources_ifdef(CONFIG_ADC_SAM_AFEC      adc_sam_afec.c)
-zephyr_library_sources_ifdef(CONFIG_ADC_TI_ADC108S102 adc_ti_adc108s102.c)
-
-zephyr_library_sources_ifdef(CONFIG_USERSPACE   adc_handlers.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_DW		adc_dw.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_MCUX_ADC16	adc_mcux_adc16.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_QMSI		adc_qmsi.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_SAM_AFEC	adc_sam_afec.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_TI_ADC108S102	adc_ti_adc108s102.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_NRFX_ADC	adc_nrfx_adc.c)
+zephyr_library_sources_ifdef(CONFIG_ADC_NRFX_SAADC	adc_nrfx_saadc.c)

drivers/adc/Kconfig

@@ -11,11 +11,26 @@
 #
 menuconfig ADC
 	bool "ADC drivers"
+	# All platforms that implement the ADC driver are now required to
+	# provide relevant DTS entries.
+	select HAS_DTS_ADC
 	help
-	  Enable ADC (Analog to Digital Converter) driver configuration
+	  Enable ADC (Analog to Digital Converter) driver configuration.
 
 if ADC
 
+# By selecting or not this option particular ADC drivers indicate if it is
+# required to explicitly specify analog inputs when configuring channels or
+# just the channel identifier is sufficient.
+config ADC_CONFIGURABLE_INPUTS
+	bool
+
+config ADC_ASYNC
+	bool "Enable asynchronous call support"
+	select POLL
+	help
+	  This option enables the asynchronous API calls.
+
 config SYS_LOG_ADC_LEVEL
 	int "ADC drivers log level"
 	depends on SYS_LOG
@@ -73,6 +88,8 @@ source "drivers/adc/Kconfig.dw"
 
 source "drivers/adc/Kconfig.mcux"
 
+source "drivers/adc/Kconfig.nrfx"
+
 source "drivers/adc/Kconfig.qmsi"
 
 source "drivers/adc/Kconfig.sam_afec"

drivers/adc/Kconfig.dw

@@ -25,15 +25,6 @@ config ADC_DW_CALIBRATION
 	  If disabled, the ADC will require the application/system-integrator
 	  to provide a calibration method.
 
-config ADC_DW_DUMMY_CONVERSION
-	bool "Enable dummy conversion"
-	default y
-	help
-	  After awaking from low power state a dummy
-	  conversion must be performed and discarded.
-	  If disabled the user will have to discard the first
-	  sample after a resume from a low power state.
-
 choice
 	prompt "Output Mode"
 	default ADC_DW_SERIAL
@@ -48,20 +39,6 @@ config ADC_DW_PARALLEL
 
 endchoice
 
-choice
-	prompt "Sequence Mode"
-	default ADC_DW_SINGLESHOT
-	help
-	  ADC sequence mode - single run/repetitive
-
-config ADC_DW_SINGLESHOT
-	bool "Single Ended"
-
-config ADC_DW_REPETITIVE
-	bool "Differential"
-
-endchoice
-
 choice
 	prompt "Capture Mode"
 	default ADC_DW_RISING_EDGE
@@ -77,20 +54,6 @@ config ADC_DW_FALLING_EDGE
 
 endchoice
 
-config ADC_DW_SAMPLE_WIDTH
-	int "Sample Width"
-	default 31
-	help
-	  Defines ADC device data sample width (resolution):
-
-	  - 0 = 6 bits resolution
-
-	  - 1 = 8 bits resolution
-
-	  - 2 = 10 bits resolution
-
-	  - 3 = 12 bits resolution
-
 config ADC_DW_SERIAL_DELAY
 	int "Serial Delay"
 	default 1

drivers/adc/Kconfig.mcux

@@ -9,6 +9,5 @@
 config ADC_MCUX_ADC16
 	bool "MCUX ADC16 driver"
 	depends on HAS_MCUX_ADC16
-	select HAS_DTS_ADC
 	help
 	  Enable the MCUX ADC16 driver.

drivers/adc/Kconfig.nrfx

@@ -0,0 +1,32 @@
+# Kconfig - ADC configuration options
+
+#
+# Copyright (c) 2018, Nordic Semiconductor ASA
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+
+config ADC_NRFX_ADC
+	bool "nRF ADC nrfx driver"
+	depends on HAS_HW_NRF_ADC
+	select NRFX_ADC
+	select ADC_CONFIGURABLE_INPUTS
+	help
+	  Enable support for nrfx ADC driver for nRF51 MCU series.
+
+config ADC_NRFX_ADC_CHANNEL_COUNT
+	int "Number of ADC channels"
+	depends on ADC_NRFX_ADC
+	range 1 8
+	default 1
+	help
+	  Number of ADC channels to be supported by the driver. Each channel
+	  needs a dedicated structure in RAM that stores the ADC settings
+	  to be used when sampling this channel.
+
+config ADC_NRFX_SAADC
+	bool "nRF SAADC nrfx driver"
+	depends on HAS_HW_NRF_SAADC
+	select ADC_CONFIGURABLE_INPUTS
+	help
+	  Enable support for nrfx SAADC driver for nRF52 MCU series.

drivers/adc/Kconfig.qmsi

@@ -13,14 +13,7 @@ menuconfig ADC_QMSI
 	help
 	  Enable the driver implementation of the QMSI ADC IP.
 
-menuconfig ADC_QMSI_SS
-	bool "QMSI ADC Driver for the Sensor Subsystem"
-	depends on QMSI
-	select ADC_0
-	help
-	  Enable the driver implementation of the QMSI ADC IP.
-
-if ADC_QMSI || ADC_QMSI_SS
+if ADC_QMSI
 
 choice
 	prompt "Capturing Mode"
@@ -59,7 +52,6 @@ config ADC_QMSI_SERIAL_DELAY
 	  the serial output is delayed after the conversion
 	  has started.
 
-if ADC_QMSI
 config ADC_QMSI_SAMPLE_WIDTH
 	int "Sample Width"
 	default 3
@@ -73,22 +65,5 @@ config ADC_QMSI_SAMPLE_WIDTH
 	  - 2 = 10 bits resolution
 
 	  - 3 = 12 bits resolution
-endif
-
-if ADC_QMSI_SS
-config ADC_QMSI_SAMPLE_WIDTH
-	int "Sample Width"
-	default 11
-	help
-	  Defines ADC device data sample width (resolution):
-
-	  - 5 = 6 bits resolution
-
-	  - 7 = 8 bits resolution
-
-	  - 9 = 10 bits resolution
-
-	  - 11 = 12 bits resolution
-endif
 
-endif # ADC_QMSI || ADC_QMSI_SS
+endif # ADC_QMSI

drivers/adc/Kconfig.sam_afec

@@ -9,7 +9,6 @@
 menuconfig ADC_SAM_AFEC
 	bool "SAM ADC Driver"
 	depends on SOC_FAMILY_SAM
-	select HAS_DTS_ADC
 	help
 	  Enable Atmel SAM MCU Family Analog-to-Digital Converter (ADC) driver
 	  based on AFEC module.