Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt: mcumgr: grp: img_mgmt: Add slot info command #76317

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

nordicjm
Copy link
Collaborator

@nordicjm nordicjm commented Jul 26, 2024

Adds a slot info command for MCUmgr to list the available slots on a device and information surrounding them

todo:

  • Code
  • Tests
  • Documentation
  • Release notes update
  • Add equivalent functionality to MCUboot serial recovery

Fixes #59749

@nordicjm nordicjm added this to the v4.0.0 milestone Jul 26, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 26, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-mcuboot DNM This PR should not be merged (Do Not Merge) labels Jul 26, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Aug 14, 2024
@nordicjm nordicjm force-pushed the mcumgrimgslots branch 2 times, most recently from 0a04280 to 5a6da57 Compare September 9, 2024 14:37
@nordicjm nordicjm marked this pull request as ready for review September 9, 2024 14:37
@nordicjm nordicjm requested a review from de-nordic as a code owner September 9, 2024 14:37
@nordicjm nordicjm requested a review from gchwier September 9, 2024 14:37
@zephyrbot zephyrbot added Release Notes To be mentioned in the release notes area: mcumgr labels Sep 9, 2024
@nordicjm nordicjm force-pushed the mcumgrimgslots branch 4 times, most recently from bc887ab to 23fa4a1 Compare September 10, 2024 07:04
@nordicjm nordicjm assigned nordicjm and unassigned dkalowsk and mmahadevan108 Sep 10, 2024
@nordicjm nordicjm force-pushed the mcumgrimgslots branch 3 times, most recently from 602f8cc to cffaa34 Compare September 10, 2024 10:21
@zephyrbot zephyrbot added the area: Samples Samples label Sep 10, 2024
@zephyrbot zephyrbot requested a review from nashif September 10, 2024 10:22
@nordicjm nordicjm removed the area: Samples Samples label Sep 10, 2024
Adds a new command that will return information on slots
themselves, listing the slot sizes, without any internal
information about the slot data. Will also return the maximum size
of an image for a set of slots if built using sysbuild.

Signed-off-by: Jamie McCrae <[email protected]>
Adds documentation describing the new slot info command

Signed-off-by: Jamie McCrae <[email protected]>
Adds a test to exercise this new feature

Signed-off-by: Jamie McCrae <[email protected]>
Adds information on the new img mgmt slot info command

Signed-off-by: Jamie McCrae <[email protected]>
goto finish;
}

rc = flash_area_open(area_id, &fa);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to request change here, just want to not that this call could happen at the beginning of the loop, together with cashing of fa->size and immediately following it flash_area_close; this way code would look more compact.

@nashif nashif merged commit 2485102 into zephyrproject-rtos:main Sep 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcumgr Release Notes To be mentioned in the release notes
Projects
Status: Done in release 4.0
Development

Successfully merging this pull request may close these issues.

[RFC] mgmt: mcumgr: img_mgmt: Add command for listing all image slots
7 participants