Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lz4: update to release version v1.10.0 #76184

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

parthitce
Copy link
Member

LZ4 is a fast compression and only of it's kind available in Zephyr RTOS manifest. But it wasn't maintained to sync with mainline version. This commit together with 1 PR help updating to latest mainline release version of LZ4.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
lz4 zephyrproject-rtos/lz4@8e303c2 zephyrproject-rtos/lz4@11b8a1e (zephyr) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@parthitce parthitce force-pushed the dev/lz4/v1.10.0 branch 2 times, most recently from 8c5991a to 6cc1c9b Compare August 6, 2024 06:02
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code DNM This PR should not be merged (Do Not Merge) labels Aug 6, 2024
@nordicjm nordicjm requested a review from Navin-Sankar August 6, 2024 06:10
@carlescufi
Copy link
Member

@parthitce zephyrproject-rtos/lz4#2 is merged, please replace with SHA.

@parthitce
Copy link
Member Author

@parthitce zephyrproject-rtos/lz4#2 is merged, please replace with SHA.

Thanks, done.

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Aug 7, 2024
LZ4 is a fast compression and only of it's kind available
in Zephyr RTOS manifest. But it wasn't maintained to sync
with mainline version. This commit together with [1] PR
help updating to latest mainline release version of LZ4.

[1]: zephyrproject-rtos/lz4#2

Signed-off-by: Parthiban Nallathambi <[email protected]>
all the external modules related samples are part of samples/modules,
whereas lz4 is in parent. move it to sample/modules/compression/lz4

Signed-off-by: Parthiban Nallathambi <[email protected]>
lz4 is moved as optional module, add step in README to add
as project filter to include into west manifest.

Fixes: zephyrproject-rtos#65127

Signed-off-by: Parthiban Nallathambi <[email protected]>
Navin-Shankar is not part of Linumiz or Zephyr RTOS projects
anymore. Adding parthitce as colloborator for LZ4.

Signed-off-by: Parthiban Nallathambi <[email protected]>
- Navin-Sankar
- parthitce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Navin-Sankar please confirm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I confirm

Copy link
Member

@Navin-Sankar Navin-Sankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nashif nashif merged commit 77c5008 into zephyrproject-rtos:main Aug 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Process area: Samples Samples manifest manifest-lz4 size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants