Revert "init: add missing initialization of dev pointer in SYS_INIT (alternative to PR68125) #68118
Conversation
|
@barnas-michal @nashif Not sure this is the correct solution, but I'm hunting a series of regressions (#68110) that affect this configuration, so I wanted submit something that unblocks and allows me to continue. |
|
Is it problem that the |
|
If the above is the case, then the revert is not a solution, since the original fix was due to c++ (zephyr sdk) compiler complain about lack of field initialization. So the fix should be to make the code assign value in a way that will please all compilers, instead of reverting the assignment and making the c++ not compile. |
|
@lyakh : I understand that the static values are initialized to the 0, but even so, I do not think that removing the assignment is a fix here. If someone has to use zephyr in project with strict regulations and has to have this flag enabled, then the compiler will complain about lack of this assignment. Proper fix IMO, would be to make this assignment work with your compiler. If the problem is unnamed union, add some name to it and change assignment, but not remove it. |
|
@barnas-michal not related to this being the right way to "fix" or not, but we should not be fixing issues of compiler warnings only enabled outside of the project, if this compiler flag is useful we should enable it in zephyr as well and fix issues everywhere and deal with it within the project for all toolchains and support this accordingly. |
|
One alternative that seems to keep our ancient XCC toolchain happy: |
kv2019i
force-pushed
the
202401-fix-intel-tgl-xcc-build
branch
from
32280e7 to
b1dd098
Compare
|
This does not seem to be easy to keep all old/new C/C++ compilers happy (with warnings). I pushed this again to fix the commit, and also did another version of #68125 (the first one didn't pass the ARM Zephyr SDK compilers). Neither is very pretty, but given we get a hard error on SOF builds (not just a warning), we need some solution. It's not like you can not use SYS_INIT . |
kv2019i
changed the title
…acro" This reverts commit 2438dbb. This commit breaks compilation on the Cadence XCC toolchain we use for Intel Tiger Lake products (this is the oldest platform we support in Zephyr upstream for the audio DSP). Error: lib/os/p4wq.c:216: error: unknown field ‘dev’ specified in initializer lib/os/p4wq.c:216: warning: missing braces around initializer lib/os/p4wq.c:216: warning: (near initialization for ‘__init_static_init.<anonymous>’) This is XCC RG-2017.8-linux (xt-xcc version 12.0.8) Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202401-fix-intel-tgl-xcc-build
branch
from
b1dd098 to
a2e3bb8
Compare
"Very strict regulations" is very... vague; there are many different variations:
Maybe @ceolin can point to more formal guidelines and approaches. |
|
This rang a bell so I quickly searched my archives and I found that this revert is actually not just a revert. More like a re-re-revert: 153f38a cc: @fabiobaltieri
Right, otherwise we go back and forth and back and forth,... |
|
#68125 merged, closing this one. |
Fixes commit 25173f7 ("pm: device_runtime: Extend with synchronous runtime PM") Fixes compilation with gcc 4.2-based toolchain used by SOF for TGL generation products. As seen in the error message below, that gcc version requires braces for initialization of anonymous unions: ``` zephyr/soc/xtensa/intel_adsp/common/mem_window.c:62: error: unknown field ‘pm_base’ specified in initializer warning: missing braces around initializer warning: (near initialization for ‘__device_dts_ord_66.<anonymous>’) ``` This is a well-known and recurring issue, see past example(s) in zephyrproject-rtos#68118 As the Zephyr build is deterministic, I could easily verify that this commit makes zero .obj difference (when using the Zephyr SDK). Signed-off-by: Marc Herbert <[email protected]>
Fixes commit 25173f7 ("pm: device_runtime: Extend with synchronous runtime PM") Fixes compilation with gcc 4.2-based toolchain used by SOF for TGL generation products. As seen in the error message below, that gcc version requires braces for initialization of anonymous unions: ``` zephyr/soc/xtensa/intel_adsp/common/mem_window.c:62: error: unknown field ‘pm_base’ specified in initializer warning: missing braces around initializer warning: (near initialization for ‘__device_dts_ord_66.<anonymous>’) ``` This is a well-known and recurring issue, see past example(s) in #68118 As the Zephyr build is deterministic, I could easily verify that this commit makes zero .obj difference (when using the Zephyr SDK). Signed-off-by: Marc Herbert <[email protected]>
Fixes commit 25173f7 ("pm: device_runtime: Extend with synchronous runtime PM") Fixes compilation with gcc 4.2-based toolchain used by SOF for TGL generation products. As seen in the error message below, that gcc version requires braces for initialization of anonymous unions: ``` zephyr/soc/xtensa/intel_adsp/common/mem_window.c:62: error: unknown field ‘pm_base’ specified in initializer warning: missing braces around initializer warning: (near initialization for ‘__device_dts_ord_66.<anonymous>’) ``` This is a well-known and recurring issue, see past example(s) in zephyrproject-rtos#68118 As the Zephyr build is deterministic, I could easily verify that this commit makes zero .obj difference (when using the Zephyr SDK). Signed-off-by: Marc Herbert <[email protected]>
…acro"
This reverts commit 2438dbb.
This commit breaks compilation on the Cadence XCC toolchain we use for Intel Tiger Lake products (this is the oldest platform we support in Zephyr upstream for the audio DSP).
Error:
/work/zephyr/lib/os/p4wq.c:216: error: unknown field ‘dev’ specified in initializer /work/zephyr/lib/os/p4wq.c:216: warning: missing braces around initializer /work/zephyr/lib/os/p4wq.c:216: warning: (near initialization for ‘__init_static_init.’)
This is XCC RG-2017.8-linux (xt-xcc version 12.0.8)