elf_parser.py: make dependency graph output deterministic #66014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sorting objects consistently without having to specific a key. No functional change yet. Signed-off-by: Marc Herbert <[email protected]>
Python's sets are not deterministic. `devices` were already sorted but `dev_supports` is still a non-deterministic set. Sort dev_supports to make the graph output deterministic. Fixes commit 2994247 ("scripts: gen_handles: output dependency graph") It is quite ironic that this initial and non-deterministic graph commit was concurrent with and slightly delayed other commit f896fc2 ("scripts: gen_handles: Sort the device handles") which fixed another, similar non-determinism issue in the same area. A true "whack-a-mole"! Signed-off-by: Marc Herbert <[email protected]>
marc-hb
changed the title
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
fabiobaltieri
approved these changes
Dec 1, 2023
JordanYates
approved these changes
Dec 1, 2023
henrikbrixandersen
approved these changes
Dec 4, 2023
|
@tejlmand Sorry, I accidentally merged this without your approval. Please let me know if any action is needed. My apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits. Main one:
Python's sets are not deterministic.
deviceswere already sorted butdev_supportsis still anon-deterministic set. Sort dev_supports to make the graph output
deterministic.
Fixes commit 2994247 ("scripts: gen_handles: output dependency graph")
It is quite ironic that this initial and non-deterministic graph commit
was concurrent with and slightly delayed other commit
f896fc2 ("scripts: gen_handles: Sort the device handles") which
fixed another, similar non-determinism issue in the same area. A true
"whack-a-mole"!