scripts/build: make struct_tags.json deterministic #66009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not good to see struct_tags.json change from one build to the next when nothing changes. Python's sets are not deterministic, see long story for older commit f896fc2 ("scripts: gen_handles: Sort the device handles") Simply convert multiple_directories to a sorted list before using it. Fixes commit 80e7820 ("kernel: syscalls: no need to include all syscalls in binary") Signed-off-by: Marc Herbert <[email protected]>
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
keith-zephyr
approved these changes
Dec 1, 2023
dcpleung
approved these changes
Dec 1, 2023
JordanYates
approved these changes
Dec 2, 2023
carlescufi
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not good to see struct_tags.json change from one build to the next when nothing changes.
Python's sets are not deterministic, see long story for older commit f896fc2 ("scripts: gen_handles: Sort the device handles")
Simply convert multiple_directories to a sorted list before using it.
Fixes commit 80e7820 ("kernel: syscalls: no need to include all syscalls in binary")