devicetree: remove label property accessors #66001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
galak,
henrikbrixandersen,
kartben and
MaureenHelm
These were first deprecated in v3.2. We have kept support for them for as long as we can, but now their presence is causing CI failures in some configurations. Specifically, using the deprecated 'label' property is causing a warning which is promoted to an error in some twister runs. This is blocking other forward progress in the devicetree API. I tried to rework the tests to avoid this, but it was too much effort for the time I had to work on the task. Removing the APIs is therefore unfortunately the best way forward to unblocking other work. Re-work the test suite a bit to maintain coverage where we are using the label property to test other macros. Add a migration guide section to help with the transition. Signed-off-by: Martí Bolívar <[email protected]>
mbolivar-ampere
force-pushed
the
remove-dt-label-property-accessors
branch
from
7989dac to
0426743
Compare
henrikbrixandersen
approved these changes
Dec 1, 2023
teburd
approved these changes
Dec 1, 2023
|
@mbolivar-ampere a kind reminder that PRs should generally stay open for at least two business days before getting merged. https://docs.zephyrproject.org/latest/project/project_roles.html#merge-criteria |
mbolivar-ampere
added
the
Hotfix
|
@kartben Thanks for the reminder! I think there is no problem here, though. That document states:
Where a hotfix is defined as an issue that is blocking development. This certainly qualifies. I have added the label since it was missing just for the record. |
|
Sounds good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were first deprecated in v3.2. We have kept support for them for as long as we can, but now their presence is causing CI failures in some configurations. Specifically, using the deprecated 'label' property is causing a warning which is promoted to an error in some twister runs. This is blocking other forward progress in the devicetree API.
I tried to rework the tests to avoid this, but it was too much effort for the time I had to work on the task. Removing the APIs is therefore unfortunately the best way forward to unblocking other work.
Re-work the test suite a bit to maintain coverage where we are using the label property to test other macros.
Add a migration guide section to help with the transition.