Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ieee802154: Fix how is initialized the driver lock in l2 test #650

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

tbursztyka
Copy link
Collaborator

@tbursztyka tbursztyka commented Jun 30, 2017

The test starts the last one: after the driver and the net stack.
However, the net stack (due to DAD and else) will already try to send
some packet, resulting in giving an uninitialized semaphore. But once
properly initialized, this semaphore will end up with a non-zero count
when the test will start: thus resetting it to 0 before running the
tests.

Jira: ZEP-2319

Reported-by Andrew Boie [email protected]

Signed-off-by: Tomasz Bursztyka [email protected]

The test starts the last one: after the driver and the net stack.
However, the net stack (due to DAD and else) will already try to send
some packet, resulting it giving a uninitialized semaphore. But once
properly initialized, this semaphore will end up with a non-zero count
when the test will start: thus reseting it to 0 before running the
tests.

Jira: ZEP-2319

Reported-by Andrew Boie <[email protected]>

Signed-off-by: Tomasz Bursztyka <[email protected]>
@tbursztyka
Copy link
Collaborator Author

recheck

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch itself is ok, the subject has a typo so instead of saying "Fix how is initialized the driver lock..." it should say "Fix how the driver lock is initialized..."

@nashif nashif merged commit 37af7b5 into zephyrproject-rtos:master Jul 4, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
…ect-rtos#650)

This improves the basic syntax to:
var assert = require('Assert');
assert(true, "successful assertion");
assert(false, "failed assertion");

Also allow any "truthy" value to pass. If you explicitly want to check for
exact equality with true, then do:
assert(operation() === true, "perform operation");

Relax about argument types; equal can check non-object arguments. The
description argument can be a non-string or doesn't have to be given.

Swapped argument order in assert.throws() to match Node API.

Signed-off-by: Geoff Gustafson <[email protected]>
parthitce pushed a commit to linumiz/zephyr that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants