Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: dac loopback test on stm32 boards #56853

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Apr 14, 2023

Add configuration to run the tests/drivers/dac/dac_loopback on more stm32 platforms.

Adapting the ADC input channels for running the testcase tests/drivers/dac/dac_loopback on
(new version of the #50742)

nucleo_l073rz adc1 input read from A0 --> connect to A2 on CN8
nucleo_g071rb adc1 input read from A0 --> connect to A2 on CN8
stm32l562e_dk adc1 input 13 from A4 --> connect to A2 on CN19

Requires the #58931

Add the connection on the hw board and the dac_adc_loopback fixture to Pass the test.

Signed-off-by: Francois Ramu [email protected]

@FRASTM FRASTM marked this pull request as ready for review April 28, 2023 12:38
@FRASTM FRASTM requested a review from nashif as a code owner April 28, 2023 12:38
@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) platform: STM32 ST Micro STM32 area: DAC Digital-to-Analog Converter labels Apr 28, 2023
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the changes to the ADC clock dividers required? Would be good to state the reason in the commit message.

If that's a bug in the ADC driver, I'd suggest to open a dedicated PR for that.

gautierg-st
gautierg-st previously approved these changes Jun 7, 2023
@FRASTM
Copy link
Collaborator Author

FRASTM commented Jun 7, 2023

Why are the changes to the ADC clock dividers required? Would be good to state the reason in the commit message.

If that's a bug in the ADC driver, I'd suggest to open a dedicated PR for that.

removed in this new version

@martinjaeger martinjaeger added the DNM This PR should not be merged (Do Not Merge) label Jun 7, 2023
@martinjaeger
Copy link
Member

martinjaeger commented Jun 7, 2023

Added DNM in order to wait until #58932 is merged.

Change the pinout for ADC/DAC loopback testing on the stm32 boards
nucleo_l073rz: adc_in0_pa0/dac_out1_pa4 --> A0 to A2 on arduino CN8
nucleo_g071rb: adc1_in0_pa0/dac1_out1_pa4 --> A0 to A2 on arduino CN8
stm32l562e_dk: adc1_in13_pc4/dac1_out1_pa4 --> A2 to A4 on arduino CN19
Adjust the ACQuisition time to the MAX value because the default (=0)
is too low for several boards.

Signed-off-by: Francois Ramu <[email protected]>
@FRASTM
Copy link
Collaborator Author

FRASTM commented Jun 8, 2023

Rebased on c8a9634
Fix the ACQ time with MAX value (instead of 0) for stm32 boards.

--> all tests PASSED on
- nucleo_f207zg
- nucleo_l073rz
- nucleo_l152re
- stm32f3_disco
- stm32l562e_dk
- nucleo_f429zi
- nucleo_f746zg
- nucleo_g071rb
- nucleo_wl55jc

@FRASTM FRASTM marked this pull request as ready for review June 8, 2023 14:11
@FRASTM FRASTM requested a review from gautierg-st June 8, 2023 14:11
@FRASTM FRASTM removed the DNM This PR should not be merged (Do Not Merge) label Jun 8, 2023
@FRASTM FRASTM removed the request for review from ABOSTM June 8, 2023 14:16
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@nashif nashif merged commit 433114e into zephyrproject-rtos:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants