usb: device_next: add CDC ECM class implementation #54448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
added
area: USB
zephyrbot
added
area: Devicetree Binding
56 tasks
jfischer-no
force-pushed
the
pr-device-next-cdc-ecm
branch
from
4d00db9 to
35666b8
Compare
tmon-nordic
requested changes
Mar 6, 2023
| */ | ||
| #define CDC_ECM_IMAC_BASE 4 | ||
|
|
||
| #define CDC_ECM_IFACE_UP 0 |
There was a problem hiding this comment.
I think enum fits the purpose here better than defines.
| int ret; | ||
|
|
||
| if (!atomic_test_bit(&data->state, CDC_ECM_CLASS_ENABLED)) { | ||
| return -EPERM; |
There was a problem hiding this comment.
I think ENODEV better reflects the error here.
There was a problem hiding this comment.
ENODEV is confusing because there is a device but it can not be used yet, I would like to use EACCES and align it with 562d799#r1126070376
| } | ||
|
|
||
| if (atomic_test_bit(&data->state, CDC_ECM_CLASS_SUSPENDED)) { | ||
| LOG_INF("USB support is suspended (FIXME)"); |
There was a problem hiding this comment.
"USB device" is suspended, not "USB support"
| if (!atomic_test_bit(&data->state, CDC_ECM_CLASS_ENABLED) || | ||
| !atomic_test_bit(&data->state, CDC_ECM_IFACE_UP)) { | ||
| LOG_INF("Configuration is not enabled or interface not ready"); | ||
| return -EACCES; |
There was a problem hiding this comment.
I think ENODEV is more appropriate here.
| #define USBD_CDC_ECM_DT_DEVICE_DEFINE(n) \ | ||
| CDC_ECM_DEFINE_DESCRIPTOR(n); \ | ||
| USBD_DESC_STRING_DEFINE(mac_desc_nd_##n, \ | ||
| DT_INST_PROP_OR(n, mac_address, "00005E005301"),\ |
There was a problem hiding this comment.
If MAC address is changed to require property this hardcoded fallback will no longer be necessary.
GeorgeCGV
reviewed
Apr 14, 2023
GeorgeCGV
reviewed
Apr 14, 2023
GeorgeCGV
reviewed
Apr 14, 2023
Add bindings for CDC ECM virtual ethernet controller. Signed-off-by: Johann Fischer <[email protected]>
Add CDC Ethernet Control Model class implementation for the new experimental USB device support based on the existing implementation subsys/usb/device/class/netusb/function_ecm.c. The implementation forms virtual ethernet connection between USB host and USB device and requires two corresponding MAC addresses, one for the virtual interface on the device side, and other for the host which is described by a string descriptor. With upcoming changes it should also possible to use a real ethernet controller as media access on the device side. CDC ECM implementation supports multiple instances which are specified using DT. The number of instances is limited by the number of endpoints on the controller, two to three should usually be possible. Signed-off-by: Johann Fischer <[email protected]>
Add DT and Kconfig overlay for new experimental CDC ECM implementation. USB device support configuration and initialization can be done through shell by following commands: uart:~$ usbd config add 1 uart:~$ usbd class add cdc_ecm_0 1 uart:~$ usbd defaults uart:~$ usbd init uart:~$ usbd enable Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-device-next-cdc-ecm
branch
from
35666b8 to
8dc282c
Compare
tmon-nordic
approved these changes
Apr 24, 2023
carlescufi
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CDC Ethernet Control Model class implementation for the
new experimental USB device support based on the existing
implementation subsys/usb/device/class/netusb/function_ecm.c.
The implementation forms virtual ethernet connection between
USB host and USB device and requires two corresponding MAC
addresses, one for the virtual interface on the device side,
and other for the host which is described by a string descriptor.
CDC ECM implementation supports multiple instances which are
specified using DT. The number of instances is limited by the
number of endpoints on the controller, two to three should usually
be possible.