modules/picolibc: Include clang+cmake and old GCC changes

[keith-packard]

This updates west.yml to pull a version of picolibc that includes both the patches in #54391 as well as a proposed fix that provides some compatibility with GCC versions before 4.5, such as the GCC based XCC compiler.

Signed-off-by: Keith Packard [email protected]

Fixes #54336

[zephyrbot]

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
picolibc	zephyrproject-rtos/picolibc@2097f26 (cmake-no-tls)	zephyrproject-rtos/picolibc@0694a78 (main)	zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

[keith-packard]

This patch is still under discussion for merging to picolibc; when this feature is merged to picolibc main, I'll remove the DNM tag.

[keith-packard]

This now references the picolibc patch which was reviewed and merged upstream.

[stephanosio]

There are some failures.

[keith-packard]

There are some failures.

Zephyr and picolibc were both trying to use a macro __deprecated, but picolibc had an argument for the optional message (which old GCC didn't support). Thanks for noticing, let's see if that's fixed now.

[keith-packard]

There are some failures.

Zephyr and picolibc were both trying to use a macro __deprecated, but picolibc had an argument for the optional message (which old GCC didn't support). Thanks for noticing, let's see if that's fixed now.

Yup, looks fixed now -- the one remaining failure I'm seeing also on main, and that test isn't using picolibc.

[keith-packard]

Yup, looks fixed now -- the one remaining failure I'm seeing also on main, and that test isn't using picolibc.

And it's transient; re-running the test resolved the issue. Sigh.

[galak]

Tried this with qemu_x86 w/llvm-14 or llvm-15 on ubuntu and get the following (or some form it):

<inline asm>:2:1: error: __getauxval changed binding to STB_GLOBAL

when trying:

./scripts/twister -p qemu_x86 -T tests/lib/c_lib/

branch: https://github.com/galak/zephyr/pull/new/llvm-x86-pico

[galak]

Tried this with qemu_x86 w/llvm-14 or llvm-15 on ubuntu and get the following (or some form it):

<inline asm>:2:1: error: __getauxval changed binding to STB_GLOBAL

when trying:

./scripts/twister -p qemu_x86 -T tests/lib/c_lib/

branch: https://github.com/galak/zephyr/pull/new/llvm-x86-pico

Seems to be related to __weak_reference is expanding to:

unsigned long getauxval(unsigned long type)
{
 (void) type;
 (*z_errno_wrap()) = 22;
 return 0;
}
__asm__(".weak_reference " "__getauxval");
__asm__(".globl " "__getauxval");
__asm__(".set " "__getauxval" ", " "getauxval");

[keith-packard]

Seems to be related to __weak_reference is expanding to:

unsigned long getauxval(unsigned long type)
{
 (void) type;
 (*z_errno_wrap()) = 22;
 return 0;
}
__asm__(".weak_reference " "__getauxval");
__asm__(".globl " "__getauxval");
__asm__(".set " "__getauxval" ", " "getauxval");

Yeah, newlib (and picolibc by extension) use inline asm for weak references instead of using attributes. I'm working on a picolibc patch to make it use __attribute__((__weak__, __alias__...)) instead. Seems to fix this, but needs testing.

[keith-packard]

Yeah, newlib (and picolibc by extension) use inline asm for weak references instead of using attributes. I'm working on a picolibc patch to make it use __attribute__((__weak__, __alias__...)) instead. Seems to fix this, but needs testing.

I've updated this series to pull in picolibc with this fix from upstream.

[keith-packard]

Updated past other recent picolibc merge, does not change target manifest revision

[galak]

Based on TSC conversation today (Mar 15, 2023), please also update the SDK to point at this version of picolibc.

Whenever we update west.yml picolibc, we should also update the SDK to match.

[keith-packard]

Based on TSC conversation today (Mar 15, 2023), please also update the SDK to point at this version of picolibc.

Whenever we update west.yml picolibc, we should also update the SDK to match.

Yup, been running tests to make sure updating both will work as expected.