samples/philosophers: Make output atomic with picolibc #53575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Portability
60 tasks
stephanosio
reviewed
Jan 27, 2023
samples/subsys/portability/cmsis_rtos_v1/philosophers/src/main.c
Outdated
Show resolved
Hide resolved
samples/subsys/portability/cmsis_rtos_v1/philosophers/src/main.c
Outdated
Show resolved
Hide resolved
Picolibc doesn't have any output buffering for printk, so the various pieces of the status line would get interleaved between threads. Build the whole line in memory using snprintk and then print it in a single printk call. Signed-off-by: Keith Packard <[email protected]>
This demo prints out STARVING, HOLDING, EATING, DROPPED, THINKING. The HOLDING state was missing and the EATING state was placed in the wrong sequence. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
picolibc-phil
branch
from
3d270bd
to
ca136b1
Compare
nashif
approved these changes
Feb 24, 2023
stephanosio
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picolibc doesn't have any output buffering for printk, so the various
pieces of the status line would get interleaved between threads. Build the
whole line in memory using snprintk and then print it in a single printk
call.
This series also has a patch in the test configuration to match the
'HOLDING' status as well as place the EATING status in the right sequence.
Signed-off-by: Keith Packard [email protected]