Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/hal/openisa: Support building without -ffreestanding #51908

Merged
merged 1 commit into from
Apr 20, 2023
Merged

modules/hal/openisa: Support building without -ffreestanding #51908

merged 1 commit into from
Apr 20, 2023

Conversation

keith-packard
Copy link
Collaborator

With -ffreestanding disabled, Zephyr SDK 0.15.0 generates a potentially uninitialized variable warning that appears to be a false positive. Disable the warning around the affected code.

Signed-off-by: Keith Packard [email protected]

@zephyrbot zephyrbot added manifest west manifest-hal_openisa DNM This PR should not be merged (Do Not Merge) labels Nov 2, 2022
@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 2, 2022 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_openisa zephyrproject-rtos/hal_openisa@40d049f zephyrproject-rtos/hal_openisa@d1e61c0 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@stephanosio stephanosio added area: West West utility and removed west labels Nov 2, 2022
@keith-packard keith-packard mentioned this pull request Jan 18, 2023
Closed
60 tasks
@keith-packard keith-packard added the area: picolibc Picolibc C Standard Library label Jan 20, 2023
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 28, 2023
@keith-packard
Copy link
Collaborator Author

This is still blocking use of picolibc with this module as picolibc does not enable -ffreestanding.

@github-actions github-actions bot removed the Stale label Mar 29, 2023
@stephanosio
Copy link
Member

@keith-packard zephyrproject-rtos/hal_openisa#7 has been merged.

@keith-packard
modules/hal/openisa: Support building without -ffreestanding
07b5860 
With -ffreestanding disabled, Zephyr SDK 0.15.0 generates a potentially
uninitialized variable warning that appears to be a false positive. Pull
in the upstream version of the module which contains the fix.

Signed-off-by: Keith Packard <[email protected]>
@keith-packard
Copy link
Collaborator Author

@keith-packard zephyrproject-rtos/hal_openisa#7 has been merged.

Thanks, I've rebased and updated to use the commit ID from upstream.

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Apr 18, 2023
@carlescufi carlescufi merged commit d72b791 into zephyrproject-rtos:main Apr 20, 2023
@keith-packard keith-packard deleted the hal_openisa-ffreestanding branch April 20, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanosio stephanosio stephanosio approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees

@dleach02 dleach02

Labels
area: picolibc Picolibc C Standard Library area: West West utility manifest manifest-hal_openisa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keith-packard @zephyrbot @stephanosio @MaureenHelm @carlescufi @dleach02