twister: treat imgtool image exceeded as flash overflow #50449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twister detects FLASH overflow and skips tests that trigger that condition by default, but sometimes images are just on the flash size limit and then overflows at a later stage when imgtool adds a trailer, which gets detected as a build fail and fails the run. This detects the imgtool flash overflow together with the normal build ones, causing the build to be skipped on imgtool flash overflow as well. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
twister-imgtool-overflow
branch
from
f01f3ff to
5598286
Compare
enjiamai
approved these changes
Sep 21, 2022
stephanosio
approved these changes
Sep 21, 2022
chen-png
approved these changes
Sep 21, 2022
nashif
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twister detects FLASH overflow and skips tests that trigger that condition by default, but sometimes images are just on the flash size limit and then overflows at a later stage when imgtool adds a trailer, which gets detected as a build fail and fails the run.
This detects the imgtool flash overflow together with the normal build ones, causing the build to be skipped on imgtool flash overflow as well.
Fixes #50386
(tested with
./scripts/twister -v -p lpcxpresso55s69_ns -T samples/net/sockets/http_get)