Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Create a module for picolibc #44096

Merged
merged 10 commits into from
Jun 22, 2022

Conversation

keith-packard
Copy link
Collaborator

@keith-packard keith-packard commented Mar 22, 2022

Rather than depending on the toolchain, create a module for picolibc and build it along with Zephyr. This has a few hacks to make it work; I'm mostly curious if this seems like a reasonable direction for picolibc integration. I've set it up to just use 'meson' to configure and build picolibc for now.

Closes #44143

@carlescufi
Copy link
Member

Thanks @keith-packard, would you mind creating an issue as described here so we can proceed with the creation of a mirror repo after a TSC vote?

@carlescufi
Copy link
Member

Please ignore the "Manifest" job failure, that's a bug on the bot side.

@zephyrbot zephyrbot added area: Formatting Output area: POSIX POSIX API Library area: Base OS Base OS Library (lib/os) labels Mar 23, 2022
@keith-packard
Copy link
Collaborator Author

ok, I'll try to hold this version stable long enough to get a couple of approvals so we can just get 'er merged. If you have any comments about changes that are required, if they're relatively minor, let's plan on doing minor PRs after the merge to fix things up instead of delaying the merge.

Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool by me, certainly. Nothing really impactful is happening in the Zephyr tree that I can see, mostly cleanup for existing weirdness.

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi merged commit d0a7886 into zephyrproject-rtos:main Jun 22, 2022
@keith-packard keith-packard deleted the picolibc-module branch June 22, 2022 19:15
@enjiamai
Copy link
Collaborator

Hi @keith-packard, the commit of the picolibc repo seems like a incorrect reversion in the west.yml. It will cause west update failed. Could you please help on correcting it? thanks.

199     - name: picolibc
200       path: modules/lib/picolibc
201       revision: 4f8076520240192be284843a114c92853e29bbbc

I cannot find this commit: 4f8076520240192be284843a114c92853e29bbbc in https://github.com/zephyrproject-rtos/picolibc

@enjiamai
Copy link
Collaborator

Update: it works after 0984aed got merged. thanks. Please ignore below comments, thanks!

@keith-packard
Copy link
Collaborator Author

Update: it works after 0984aed got merged. thanks. Please ignore below comments, thanks!

Sorry for messing up the zephyr/picolibc repo -- looks like we've got a process in place now with the ability to FF the main branch.

@stephanosio stephanosio added the Release Notes To be mentioned in the release notes label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: ARM ARM (32-bit) Architecture area: Base OS Base OS Library (lib/os) area: Boards area: Build System area: C Library C Standard Library area: Formatting Output area: Kconfig area: Kernel area: Logging area: Modules area: Networking area: POSIX POSIX API Library area: RISCV RISCV Architecture (32-bit & 64-bit) area: Samples Samples area: Shields Shields (add-on boards) area: Tests Issues related to a particular existing or missing test manifest manifest-hal_ti manifest-picolibc platform: ITE ITE platform: X86 x86 and x86-64 Release Notes To be mentioned in the release notes RFC Request For Comments: want input from the community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adding picolibc as a module
9 participants