-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Create a module for picolibc #44096
RFC: Create a module for picolibc #44096
Conversation
Thanks @keith-packard, would you mind creating an issue as described here so we can proceed with the creation of a mirror repo after a TSC vote? |
Please ignore the "Manifest" job failure, that's a bug on the bot side. |
ok, I'll try to hold this version stable long enough to get a couple of approvals so we can just get 'er merged. If you have any comments about changes that are required, if they're relatively minor, let's plan on doing minor PRs after the merge to fix things up instead of delaying the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool by me, certainly. Nothing really impactful is happening in the Zephyr tree that I can see, mostly cleanup for existing weirdness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @keith-packard, the commit of the picolibc repo seems like a incorrect reversion in the west.yml. It will cause west update failed. Could you please help on correcting it? thanks.
I cannot find this commit: 4f8076520240192be284843a114c92853e29bbbc in https://github.com/zephyrproject-rtos/picolibc |
Update: it works after 0984aed got merged. thanks. Please ignore below comments, thanks! |
Sorry for messing up the zephyr/picolibc repo -- looks like we've got a process in place now with the ability to FF the main branch. |
Rather than depending on the toolchain, create a module for picolibc and build it along with Zephyr. This has a few hacks to make it work; I'm mostly curious if this seems like a reasonable direction for picolibc integration. I've set it up to just use 'meson' to configure and build picolibc for now.
Closes #44143