Revert "logging: Prevent multiple arguments evaluation" #42609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f56567 which caused build failures with the XCC toolchain on all samples and tests, as well as a runtime failure with the nrf52_bsim board on tests/bluetooth/bsim_bt/bsim_test_mesh. Signed-off-by: Maureen Helm <[email protected]>
MaureenHelm
added
the
Hotfix
github-actions
bot
added
area: API
dcpleung
approved these changes
Feb 8, 2022
nashif
approved these changes
Feb 8, 2022
|
need to revert 2nd commit |
This reverts commit f647201. Signed-off-by: Maureen Helm <[email protected]>
|
The reason is increased stack usage when optimization is off (case for nrf52_bsim), i'm reworking to avoid stack increase. I will also add test which will be estimating stack required for logging to catch when it increases. Initial tests show that it varies a lot between platforms. |
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f56567 which
caused build failures with the XCC toolchain on all samples and tests,
as well as a runtime failure with the nrf52_bsim board on
tests/bluetooth/bsim_bt/bsim_test_mesh.
Signed-off-by: Maureen Helm [email protected]
Fixes #42608