cmake: package_helper CMake script #41302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
force-pushed
the
zephyr_package_tooling
branch
2 times, most recently
from
944ae90 to
3c3c3d0
Compare
tejlmand
force-pushed
the
zephyr_package_tooling
branch
from
3c3c3d0 to
14f8391
Compare
tejlmand
force-pushed
the
zephyr_package_tooling
branch
from
14f8391 to
3fa7b06
Compare
zephyrbot
requested review from
andyross,
ceolin,
chen-png,
dcpleung,
enjiamai,
galak,
gmarull,
gopiotr,
hakehuang,
PerMac,
peter-mitsis,
SebastianBoe and
utzig
and removed request for
mbolivar-nordic
tejlmand
force-pushed
the
zephyr_package_tooling
branch
from
cd0aae1 to
1849402
Compare
SebastianBoe
reviewed
Feb 1, 2022
SebastianBoe
reviewed
Feb 1, 2022
SebastianBoe
reviewed
Feb 2, 2022
tejlmand
force-pushed
the
zephyr_package_tooling
branch
2 times, most recently
from
be58359 to
abdcd6d
Compare
cmake/package_tooling.cmake
Outdated
| # | ||
| # Copyright (c) 2021, Nordic Semiconductor ASA | ||
|
|
||
| # The Zephyr package tooling script provides a generic script mode interface |
There was a problem hiding this comment.
How about package_helper?
tejlmand
force-pushed
the
zephyr_package_tooling
branch
from
abdcd6d to
8751a0f
Compare
cmake/modules/zephyr_default.cmake
Outdated
| endforeach() | ||
|
|
||
| if(NOT DEFINED SUB_COMPONENTS) | ||
| include(kernel) |
There was a problem hiding this comment.
shouldn't we unconditionally include kernel?
If SUB_COMPONENTS is defined the program will have returned before now.
There was a problem hiding this comment.
good point.
after the cleanup, this if can be removed.
will do.
SebastianBoe
previously approved these changes
Feb 16, 2022
tejlmand
force-pushed
the
zephyr_package_tooling
branch
3 times, most recently
from
1467560 to
9423439
Compare
tejlmand
changed the title
mbolivar-nordic
previously approved these changes
Feb 18, 2022
This commit allows to load only subcomponents of the default Zephyr CMake module, zephyr_default.cmake. This allows other tools to execute Zephyr CMake build system up to a specific module and the stop further processing. This commit is an enabler for future support in twister to process only devicetree or kconfig, to allow test / sample filtering before generating a complete build system. Sub-components can be loaded as: > find_package(Zephyr COMPONENTS zephyr_default:<sub-component>) for example: > find_package(Zephyr COMPONENTS zephyr_default:dts) Signed-off-by: Torsten Rasmussen <[email protected]>
The Zephyr CMake package helper script allows to invoke Zephyr package modules as they are invoked at configure time, up to the modules given with `-DMODULES=<modules>`. This allows to run the configure time part of the Zephyr build system without generating a complete build system. This means that for example devicetree module can be invoked for a given sample and board to generate zephyr.dts identical to what is created by the build system during a build. To generate zephyr.dts for hello_world, invoke the script as: $ cmake -DBOARD=<board> -B build -S samples/hello_world \ $ -DMODULES=dts -P <ZEPHYR_BASE>/cmake/package_helper.cmake Other modules, for example 'kconfig' and 'zephyr_modules' can also be invoked this way. This will allow other tools, such as twister, to executed only a subset of the build system like dts in order to do filtering before determine if a complete build should be invoked. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
zephyr_package_tooling
branch
from
9423439 to
f75862c
Compare
|
Re-based, @mbolivar-nordic @SebastianBoe please re-approve. |
SebastianBoe
approved these changes
Feb 23, 2022
mbolivar-nordic
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zephyr CMake package helper script allows to invoke Zephyr package
modules as they are invoked at configure time, up to the modules given
with
-DMODULES=<modules>.This allows to run the configure time part of the Zephyr build system
without generating a complete build system.
This means that for example devicetree module can be invoked for a given
sample and board to generate zephyr.dts identical to what is created
by the build system during a build.
To generate zephyr.dts for hello_world, invoke the script as:
$ cmake -DBOARD= -B build -S samples/hello_world
$ -DMODULES=dts -P <ZEPHYR_BASE>/cmake/package_helper.cmake
Other modules, for example 'kconfig' and 'zephyr_modules' can also be
invoked this way.
This will allow other tools, such as twister, to executed only a
subset of the build system like dts in order to do filtering before
determine if a complete build should be invoked.
Signed-off-by: Torsten Rasmussen [email protected]
NOTE Ignore first commit, it's a squash of #41301.