samples: bluetooth: hci_usb: Add support for bl654_usb #39905
Conversation
Fixes an issue with the USB CDC port being enabled which prevented running the sample application Signed-off-by: Jamie McCrae <[email protected]>
| @@ -0,0 +1,2 @@ | |||
| CONFIG_USB_CDC_ACM=n | |||
There was a problem hiding this comment.
I do not think we should start with that, that can be handled at board level, if your board enables USB per default then it should handle this configuration there as well. Otherwise we will soon have many trivial overlays here.
There was a problem hiding this comment.
USB CDC is enabled by default so it can be used as an input/output, the overlay is here because in this specific sample it needs to use the USB for a bluetooth transport.
There was a problem hiding this comment.
diff --git a/boards/arm/bl654_usb/Kconfig.defconfig b/boards/arm/bl654_usb/Kconfig.defconfig
index 56125667cb..99e269f524 100644
--- a/boards/arm/bl654_usb/Kconfig.defconfig
+++ b/boards/arm/bl654_usb/Kconfig.defconfig
@@ -26,7 +26,10 @@ config FLASH_LOAD_OFFSET
if USB_DEVICE_STACK
config USB_UART_CONSOLE
- default y
+ default y if !USB_DEVICE_BLUETOOTH
+
+config USB_CDC_ACM
+ default n if USB_DEVICE_BLUETOOTH
config UART_LINE_CTRL
default yokay?
There was a problem hiding this comment.
What's changed in zephyr? As far as I can see, current top of tree, USB CDC is broken. shell_module enumerates as a CDC device which then doesn't give any output or accept any input, hci_usb works, any other sample application with UART/log output with output set for CDC never enumerates as a USB device
There was a problem hiding this comment.
What's changed in zephyr?
Please read release notes.
Fixes an issue with the USB CDC port being enabled which prevented
running the sample application
Signed-off-by: Jamie McCrae [email protected]
Fixes #39904