cmake: increase minimal required version to 3.20.0 #37575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
requested review from
nashif,
evgeniy-paltsev,
carlescufi,
daor-oti and
mbolivar-nordic
tejlmand
requested review from
aescolar,
alexanderwachter,
andyross,
asbjornsabo,
aunsbjerg,
avisconti,
ceolin,
dcpleung,
de-nordic,
galak,
henrikbrixandersen,
ioannisg,
jakub-uC,
jfischer-no,
jhedberg,
joerchan,
kgugala,
Mani-Sadhasivam,
MaureenHelm,
microbuilder,
Mierunski,
mnkp,
nandojve and
Navin-Sankar
as code owners
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
from
c22ce2d to
c7d0c86
Compare
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
2 times, most recently
from
96f4be5 to
2851230
Compare
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
from
2851230 to
85d4b7e
Compare
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
from
85d4b7e to
0270c0d
Compare
carlescufi
approved these changes
Aug 19, 2021
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
from
0270c0d to
697be8c
Compare
CMake >=3.20 requires file extensions explicitly added to source files. See CMP0115: > Starting in CMake 3.20, CMake prefers all source files to have their > extensions explicitly listed: This manifest update pulls in update for the lvgl module adding missing extension. Signed-off-by: Torsten Rasmussen <[email protected]>
Update docs to reference CMake 3.20.0 as minimum required version. Added Kitware APT repository to the getting started page. Updated installation Linux download descriptions from CMake 3.15.3 to CMake 3.21.1 as that is the version currently being installed when using the Kitware APT repository. Signed-off-by: Torsten Rasmussen <[email protected]>
Move to CMake 3.20.0. At the Toolchain WG it was decided to move to CMake 3.20.0. The main reason for increasing CMake version is better toolchain support. Better toolchain support is added in the following CMake versions: - armclang, CMake 3.15 - Intel oneAPI, CMake 3.20 - IAR, CMake 3.15 and 3.20 Signed-off-by: Torsten Rasmussen <[email protected]>
…ion" With the change to cmake_minimum_required(VERSION 3.20.0) then this commit is no longer needed. This reverts commit 6ca2bf2. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
cmake_minimum_required_3_20_0
branch
from
697be8c to
3a275e2
Compare
|
Buildkite failure is due to timeouts because of the amount of files changed --> CI runs for long time. |
nashif
approved these changes
Aug 19, 2021
|
@tejlmand consider sending email when this is merged so people know they need to update. |
tejlmand
added a commit
to tejlmand/fw-nrfconnect-nrf
that referenced
this pull request
Sep 2, 2021
Zephyr is increasing the minimum required CMake version to 3.20.0. See: zephyrproject-rtos/zephyr#37575 Therefore we update the minimum required CMake version for nRF Connect SDK to same version. Signed-off-by: Torsten Rasmussen <[email protected]>
mbolivar-nordic
pushed a commit
to nrfconnect/sdk-nrf
that referenced
this pull request
Sep 3, 2021
Zephyr is increasing the minimum required CMake version to 3.20.0. See: zephyrproject-rtos/zephyr#37575 Therefore we update the minimum required CMake version for nRF Connect SDK to same version. Signed-off-by: Torsten Rasmussen <[email protected]>
joerchan
added a commit
to joerchan/sdk-nrf
that referenced
this pull request
Oct 21, 2022
Zephyr has increasing the minimum required CMake version to 3.20.0. See: zephyrproject-rtos/zephyr#37575 A few samples were missing this update. Signed-off-by: Joakim Andersson <[email protected]>
nordicjm
pushed a commit
to nrfconnect/sdk-nrf
that referenced
this pull request
Nov 2, 2022
Zephyr has increasing the minimum required CMake version to 3.20.0. See: zephyrproject-rtos/zephyr#37575 A few samples were missing this update. Signed-off-by: Joakim Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to CMake 3.20.0.
At the Toolchain WG it was decided to move to CMake 3.20.0.
The main reason for increasing CMake version is better toolchain
support.
Better toolchain support is added in the following CMake versions:
See MoM: https://docs.google.com/document/d/1IQKBK-GcJNZG0O9QArqYfvb6Huk5xHscN-XIGEZr-z8/edit#heading=h.gc6zh884razh
Note:
DNM because the PR contains an unmerged manifest update.See: zephyrproject-rtos/lvgl#13 <-- is merged and manifest is updated to SHA revision.