-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext: simplelink: Restructure CC3220SDK as SimpleLink SDK #35
Conversation
ext/hal/ti/simplelink/Makefile
Outdated
ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx | ||
ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx/inc | ||
ZEPHYRINCLUDE +=-I$(srctree)/ext/hal/ti/simplelink/source/ti/devices/cc32xx/driverlib | ||
KBUILD_CFLAGS += -DUSE_CC3200_ROM_DRV_API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GAnthony do you means that, we are deprecate the old cc3200sdk support ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the cc3200sdk will be deprecated with the cc3200 board.
However, I just noticed something about KBUILD_CFLAGS. This patch still works with the CC3220, but to be more correct, it should be KBUILD_CFLAGS += -DUSE_CC3220_ROM_DRV_API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GAnthony thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make the fixup the Kbuild.
The SimpleLink SDK actually encapsulates a family of devices, of which cc32xx is just one device. Other devices can fit under this SDK directory structure. This expansion will also allow the import of the WiFi host driver and its driver porting layer in the future, inserted at the correct levels in the SimpleLink SDK directory heirarchy. Follow the URL (ending in "#directory-structure") referenced in ext/hal/ti/simplelink/README which explains the SDK structure, and where devices fit in. Jira: ZEP-1958 Change-Id: I16515d3e3779de0d55d3b1b8e25029609d1f66c3 Signed-off-by: Gil Pitney <[email protected]>
36a5782
to
8fcd9df
Compare
Fixed the Makefile to use KBUILD_CFLAGS=-DUSE_CC3220_ROM_DRV_API, tested on Zephyr samples, and re-pushed the commit. |
Not sure why getting "Shippable" failures on Mr. Chettimada's commit messages, when my commit has no such error. https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/200/1/tests |
No please leave this, I'm trying to figure out why this happened myself. Not sure where gitlint is getting run. |
It seems the test is running over my commit, plus several others, as if the commit wasn't rebased. |
Waiting for Anas to expose the shippable logs so we can get more details if we can reproduce it again. |
78c0221
to
a1c74b7
Compare
The SimpleLink SDK actually encapsulates a family of devices,
of which cc32xx is just one device. Other devices can fit
under this SDK directory structure.
This expansion will also allow the import of the WiFi
host driver and its driver porting layer in the future,
inserted at the correct levels in the SimpleLink SDK
directory heirarchy.
Follow the URL (ending in "#directory-structure") referenced in
ext/hal/ti/simplelink/README which explains the SDK structure,
and where devices fit in.
Jira: ZEP-1958
Change-Id: I16515d3e3779de0d55d3b1b8e25029609d1f66c3
Signed-off-by: Gil Pitney [email protected]
This change is