samples: shell_module: add shell support over CDC ACM #32586
Conversation
jfischer-no
added
area: USB
jfischer-no
force-pushed
the
pr-shell-over-cdcacm
branch
3 times, most recently
from
994ff54 to
236f787
Compare
There was a problem hiding this comment.
"console" and "shell" are distinct functions. The role of this sample is to demonstrate a console on CDC-ACM.
Demonstration of a shell on CDC-ACM should be done as a sibling samples/subsys/usb/shell, or even better added as an option in samples/subsys/shell/shell_module so the shell that's being demonstrated is actually useful.
Understand, but do not fully agree, console sample is really simple, to have that again only with 2..3 different lines makes no sense in my opinion. Also, IMO |
I care far more about console than I do about shell, so I would prefer to keep the USB console example showing how to get a USB console. That sample is what I go to for basic USB console verification, and that it generates repeated text (as I'd get from log messages on a console) is exactly what I want for its behavior. When I do want a shell, I want a shell that actually does something useful, which is |
Add shell support over CDC ACM. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-shell-over-cdcacm
branch
from
236f787 to
1d43686
Compare
jfischer-no
changed the title
|
|
||
| dev = device_get_binding(CONFIG_UART_SHELL_ON_DEV_NAME); |
There was a problem hiding this comment.
could you use const struct device *dev = DEVICE_DT_GET(DT_CHOSEN(zephyr_shell_uart));?
There was a problem hiding this comment.
That could be misleading. https://docs.zephyrproject.org/latest/reference/devicetree/api.html specifies that zephyr,shell-uart is used only to supply the default value for CONFIG_UART_SHELL_ON_DEV_NAME. The user can override the actual device through Kconfig.
It could be switched for the sample on an argument that the sample's prj.conf doesn't do that override, but that could confuse a user who finds the Kconfig then doesn't understand why the device selection code copied from the sample doesn't work.
There was a problem hiding this comment.
More relevantly: is it even possible to reference a CDC-ACM UART from devicetree? I think the answer is "no".
There was a problem hiding this comment.
More relevantly: is it even possible to reference a CDC-ACM UART from devicetree? I think the answer is "no".
It is not possible, but something to discuss, I have use case for that.
Add shell support over CDC ACM