Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: sam0: convert pinmux driver and board code to new dt macros #24656

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Apr 23, 2020

No description provided.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Apr 23, 2020

All checks passed.

checkpatch (informational only, not a failure)

-:16: WARNING:LONG_LINE: line over 80 characters
#16: FILE: boards/arm/adafruit_feather_m0_basic_proto/pinmux.c:13:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:18: WARNING:LONG_LINE: line over 80 characters
#18: FILE: boards/arm/adafruit_feather_m0_basic_proto/pinmux.c:15:
+	struct device *muxb = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_b)));

-:92: WARNING:LONG_LINE: line over 80 characters
#92: FILE: boards/arm/adafruit_trinket_m0/pinmux.c:13:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:173: WARNING:LONG_LINE: line over 80 characters
#173: FILE: boards/arm/arduino_zero/pinmux.c:13:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:174: WARNING:LONG_LINE: line over 80 characters
#174: FILE: boards/arm/arduino_zero/pinmux.c:14:
+	struct device *muxb = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_b)));

-:252: WARNING:LONG_LINE: line over 80 characters
#252: FILE: boards/arm/atsamd20_xpro/pinmux.c:13:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:253: WARNING:LONG_LINE: line over 80 characters
#253: FILE: boards/arm/atsamd20_xpro/pinmux.c:14:
+	struct device *muxb = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_b)));

-:327: WARNING:LONG_LINE: line over 80 characters
#327: FILE: boards/arm/atsamd21_xpro/pinmux.c:13:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:328: WARNING:LONG_LINE: line over 80 characters
#328: FILE: boards/arm/atsamd21_xpro/pinmux.c:14:
+	struct device *muxb = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_b)));

-:523: WARNING:LONG_LINE: line over 80 characters
#523: FILE: boards/arm/atsamr21_xpro/pinmux.c:14:
+	struct device *muxa = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_a)));

-:524: WARNING:LONG_LINE: line over 80 characters
#524: FILE: boards/arm/atsamr21_xpro/pinmux.c:15:
+	struct device *muxb = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_b)));

-:525: WARNING:LONG_LINE: line over 80 characters
#525: FILE: boards/arm/atsamr21_xpro/pinmux.c:16:
+	struct device *muxc = device_get_binding(DT_LABEL(DT_NODELABEL(pinmux_c)));

-:691: WARNING:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#691: FILE: soc/arm/atmel_sam0/common/atmel_sam0_dt.h:34:
+#define ATMEL_SAM0_DT_SERCOM_CHECK(n, compat) \
+	DT_HAS_NODE(DT_NODELABEL(sercom##n)) && \
+	DT_NODE_HAS_COMPAT(DT_NODELABEL(sercom##n), compat)

- total: 0 errors, 13 warnings, 648 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@galak galak force-pushed the dt-sam0-pinmux branch 2 times, most recently from a8a2ae4 to 9d5115a Compare April 24, 2020 12:29
Convert pinmux driver to use nodelabels to get references to devicetree
nodes using the new devicetree.h macros.

Signed-off-by: Kumar Gala <[email protected]>
Convert to using DT_NODELABEL as we phase out the old generated
devicetree macros.

Signed-off-by: Kumar Gala <[email protected]>
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SAMD20_XPRO and SAMR21_XPRO: OK

@galak galak merged commit 4d7d3a2 into zephyrproject-rtos:master Apr 25, 2020
@galak galak deleted the dt-sam0-pinmux branch April 25, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants