Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: timer: sam0_rtc_timer: Fix incorrect DT_INST conversion #24401

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Apr 15, 2020

clock-generator is a normal property. To access it we should use
DT_INST_PROP(0, clock_generator) and not DT_INST_CLOCKS_CELL().

Fixes: #24399

Signed-off-by: Kumar Gala [email protected]

@galak
Copy link
Collaborator Author

galak commented Apr 15, 2020

@sslupsky can you test this out to see if it fixes your issue.

@galak galak added block: HW Test Testing on hardware required before merging bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Apr 15, 2020
@zephyrbot zephyrbot added the area: Timer Timer label Apr 15, 2020
@sslupsky
Copy link
Contributor

@galak That was quick! Yes, that worked. Not sure why I did not try that. :-)

@galak galak removed the block: HW Test Testing on hardware required before merging label Apr 16, 2020
clock-generator is a normal property.  To access it we should use
DT_INST_PROP(0, clock_generator) and not DT_INST_CLOCKS_CELL().

Fixes: zephyrproject-rtos#24399

Signed-off-by: Kumar Gala <[email protected]>
@carlescufi carlescufi merged commit 2cd4681 into zephyrproject-rtos:master Apr 16, 2020
@nandojve nandojve mentioned this pull request Apr 18, 2020
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Timer Timer bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drivers: sam0_rtc_timer: DT_INST changes have broken this driver
4 participants