drivers: ieee802154: rf2xx: Add EUI-64 from DT and iface no auto start #24096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandojve
requested review from
galak,
jukkar,
MaureenHelm and
tbursztyka
as code owners
nandojve
added
DNM
nandojve
changed the title
nandojve
force-pushed
the
at86rf233_add_local_mac_address
branch
from
cb65946
to
79e5fde
Compare
nandojve
changed the title
nandojve
changed the title
tbursztyka
requested changes
Apr 17, 2020
61 tasks
Add local-mac-address on DT and enable it on rf2xx driver. If user define local-mac-address this value will be used as default mac address. Otherwise driver automatically add a random mac address. On application level user can change default mac address using net_mgmt command with NET_REQUEST_IEEE802154_SET_EXT_ADDR parameter defined on include/net/ieee802154_mgmt.h header. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
at86rf233_add_local_mac_address
branch
from
79e5fde
to
906a1e2
Compare
nandojve
changed the title
nandojve
force-pushed
the
at86rf233_add_local_mac_address
branch
from
906a1e2
to
f2482d9
Compare
|
The new proposal: if for any reason CONFIG_IEEE802154_RF2XX_NET_IF_NO_AUTO_START should be defined as true, who did that should call net_if_up() at some point. |
tbursztyka
approved these changes
Apr 24, 2020
jukkar
reviewed
Apr 24, 2020
Add a Kconfig option that allows user to set any necessary config using management interface before interface be operational. A use case is set the EUI-64 address from an external EEPROM by the NET_REQUEST_IEEE802154_SET_EXT_ADDR command. After all configs are done net_if_up() can be invoked to bring interface up. Fixes zephyrproject-rtos#23193. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
at86rf233_add_local_mac_address
branch
from
f2482d9
to
63a95dd
Compare
jukkar
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add local-mac-address on DT and enable it on rf2xx driver. If user define local-mac-address this value will be used as default mac address. Otherwise driver automatically add a random mac address.
On application level user can change default mac address using net_mgmt command with NET_REQUEST_IEEE802154_SET_EXT_ADDR parameter defined on include/net/ieee802154_mgmt.h header.
Refactor get_mac to rf2xx_get_mac and turn it as a weak method. This allows any user to create their own set mac address. This is important because RF2xx is a transceiver over SPI and may need mac address be defined when system is booting.Add a Kconfig option that sets NET_IF_NO_AUTO_START at driver init. This way user can control when net_if will be up with proper configuration.
Fixes #23193
Signed-off-by: Gerson Fernando Budke [email protected]