Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: atmel sam: Convert atmel sam drivers to new DT_INST macros #23740

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Mar 24, 2020

Convert older DT_INST_ macro use in atmel sam drivers to the new
include/devicetree.h DT_INST macro APIs.

Signed-off-by: Kumar Gala [email protected]

Convert older DT_INST_ macro use in atmel sam drivers to the new
include/devicetree.h DT_INST macro APIs.

Signed-off-by: Kumar Gala <[email protected]>
@galak galak added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Mar 24, 2020
@zephyrbot zephyrbot added area: PWM Pulse Width Modulation area: Watchdog Watchdog labels Mar 24, 2020
@zephyrbot
Copy link
Collaborator

All checks passed.

checkpatch (informational only, not a failure)

-:75: WARNING:LONG_LINE: line over 80 characters
#75: FILE: drivers/flash/flash_sam.c:268:
+	for (i = offset; i < offset + len; i += DT_INST_PROP(0, erase_block_size)) {

-:85: WARNING:LONG_LINE: line over 80 characters
#85: FILE: drivers/flash/flash_sam.c:316:
+	.pages_count = (CONFIG_FLASH_SIZE * 1024) / DT_INST_PROP(0, erase_block_size),

-:117: WARNING:LONG_LINE: line over 80 characters
#117: FILE: drivers/gpio/gpio_sam.c:338:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(0, ngpios)),

-:126: WARNING:LONG_LINE: line over 80 characters
#126: FILE: drivers/gpio/gpio_sam.c:366:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(1, ngpios)),

-:135: WARNING:LONG_LINE: line over 80 characters
#135: FILE: drivers/gpio/gpio_sam.c:394:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(2, ngpios)),

-:144: WARNING:LONG_LINE: line over 80 characters
#144: FILE: drivers/gpio/gpio_sam.c:422:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(3, ngpios)),

-:153: WARNING:LONG_LINE: line over 80 characters
#153: FILE: drivers/gpio/gpio_sam.c:450:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(4, ngpios)),

- total: 0 errors, 7 warnings, 216 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@galak galak merged commit 3af49c5 into zephyrproject-rtos:master Mar 26, 2020
@galak galak deleted the dt-new-inst-sam branch March 26, 2020 21:31
@nandojve nandojve mentioned this pull request Apr 4, 2020
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: PWM Pulse Width Modulation area: Watchdog Watchdog platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants