Support Ethernet on SAM E5x #23300
Merged
Support Ethernet on SAM E5x #23300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
requested review from
benpicco,
carlescufi,
finikorg,
galak,
ioannisg,
jfischer-no,
jukkar,
MaureenHelm,
nashif,
pfalcon and
tbursztyka
as code owners
stephanosio
added
area: Drivers
area: Ethernet
platform: Microchip SAM
zephyrbot
added
area: Devicetree
area: Boards
area: API
|
All checks passed. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
stephanosio
force-pushed
the
sam_e54_ethernet
branch
from
725e549
to
503d255
Compare
|
Rebased |
galak
reviewed
Apr 1, 2020
stephanosio
force-pushed
the
sam_e54_ethernet
branch
from
503d255
to
4af6285
Compare
galak
reviewed
Apr 2, 2020
galak
reviewed
Apr 2, 2020
galak
requested changes
Apr 2, 2020
stephanosio
force-pushed
the
sam_e54_ethernet
branch
2 times, most recently
from
e4d5139
to
6ad8ed7
Compare
nandojve
approved these changes
Apr 6, 2020
stephanosio
force-pushed
the
sam_e54_ethernet
branch
from
6ad8ed7
to
722146d
Compare
stephanosio
force-pushed
the
sam_e54_ethernet
branch
from
722146d
to
20c9f49
Compare
This commit adds a GMAC instance to the SAM E5x device tree, along with the refactoring necessary to specify the SAM E5x-specific components. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit enables the GMAC (Ethernet) instance in the `atsame54_xpro` device tree. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds the MCLK clock configuration symbol fix-up for the GMAC peripheral. The APB-agnostic clock configuration fix-up symbols map to the SoC-specific APB, in order to accommodate different SoC variants with the GMAC on different APBs. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds the GMAC driver support for the Ethernet-capable SAM0 family devices (SAM E53 and E54 at this time). Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds more pin function definitions (PINMUX_FUNC_I through PINMUX_FUNC_P) to the pinmux interface header. The SAM D5x and E5x series devices, for instances, define up to the "function N" and this change is necessary to support such devices. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds a reference to the SAM E54 maximum queue count value in the device tree for specifying the range of `ETH_SAM_GMAC_QUEUES` configuration. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit enables the GMAC Ethernet support for the `atsame54_xpro` board which includes an on-board RMII PHY. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
sam_e54_ethernet
branch
from
20c9f49
to
76196ad
Compare
|
Rebased, verified working on @galak Could you revisit this? Your reviews comments were addressed and your change request is still pending. |
galak
reviewed
Apr 17, 2020
| @@ -18,6 +18,7 @@ config ETH_SAM_GMAC_QUEUES | |||
| range 1 $(dt_node_int_prop_int,/soc/ethernet@40050088,num-queues) if SOC_SERIES_SAME70 || \ | |||
| SOC_SERIES_SAMV71 | |||
| range 1 $(dt_node_int_prop_int,/soc/ethernet@40034000,num-queues) if SOC_SERIES_SAM4E | |||
| range 1 $(dt_node_int_prop_int,/soc/ethernet@42000800,num-queues) if SOC_SERIES_SAME54 | |||
There was a problem hiding this comment.
I'd still prefer to remove this dt_node_int_prop_int
galak
approved these changes
Apr 17, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a series of commits to support the GMAC Ethernet peripheral on the Atmel SAM0 family devices, and enable Ethernet support on the Atmel SAM E53 and E54 SoCs.
Closes #23001.
NOTE: This patch has been tested and verified working on the
atsame54_xproboard using thesamples/net/dhcpv4_clientsample.