Add GMAC device tree binding #23045

stephanosio · 2020-02-24T07:03:34Z

This PR adds the device tree binding for the Atmel SAM GMAC Ethernet and converts the existing compatible SoCs (SAM E70 and V71) and boards (sam_e70_xplained and sam_v71_xult) to use it.

Includes commits from #23055.

Fixes #22997.

stephanosio · 2020-02-24T07:03:56Z

cc @nandojve

zephyrbot · 2020-02-24T07:13:45Z

All checks are passing now.

checkpatch (informational only, not a failure)

-:45: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,sam_e70_xplained" appears un-documented -- check ./dts/bindings/
#45: FILE: boards/arm/sam_e70_xplained/sam_e70_xplained-common.dtsi:11:
+	compatible = "atmel,sam_e70_xplained", "atmel,same70q21", "atmel,same70";

-:45: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,same70q21" appears un-documented -- check ./dts/bindings/
#45: FILE: boards/arm/sam_e70_xplained/sam_e70_xplained-common.dtsi:11:
+	compatible = "atmel,sam_e70_xplained", "atmel,same70q21", "atmel,same70";

-:45: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,same70" appears un-documented -- check ./dts/bindings/
#45: FILE: boards/arm/sam_e70_xplained/sam_e70_xplained-common.dtsi:11:
+	compatible = "atmel,sam_e70_xplained", "atmel,same70q21", "atmel,same70";

-:45: WARNING:LONG_LINE: line over 80 characters
#45: FILE: boards/arm/sam_e70_xplained/sam_e70_xplained-common.dtsi:11:
+	compatible = "atmel,sam_e70_xplained", "atmel,same70q21", "atmel,same70";

-:368: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,sam_v71_xult" appears un-documented -- check ./dts/bindings/
#368: FILE: boards/arm/sam_v71_xult/sam_v71_xult-common.dtsi:12:
+	compatible = "atmel,sam_v71_xult", "atmel,samv71q21", "atmel,samv71";

-:368: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,samv71q21" appears un-documented -- check ./dts/bindings/
#368: FILE: boards/arm/sam_v71_xult/sam_v71_xult-common.dtsi:12:
+	compatible = "atmel,sam_v71_xult", "atmel,samv71q21", "atmel,samv71";

-:368: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "atmel,samv71" appears un-documented -- check ./dts/bindings/
#368: FILE: boards/arm/sam_v71_xult/sam_v71_xult-common.dtsi:12:
+	compatible = "atmel,sam_v71_xult", "atmel,samv71q21", "atmel,samv71";

- total: 0 errors, 7 warnings, 1020 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

pfalcon

Just a comment to make this not show in my pending review list, as I'm not authority on DT stuff.

stephanosio · 2020-02-24T07:25:45Z

@ulfalizer @galak Any suggested alternative for dt_int_val, which is apparently deprecated?

stephanosio · 2020-02-24T07:48:19Z

@nandojve I am adding you as the SAM E70 platform code owner, since there currently is none and the Codeowners check is complaining about it.

stephanosio · 2020-02-24T10:13:46Z

We are currently seeing USB-related build errors for SAMV71B because the ASF usbhs.h header in hal_atmel is missing some definitions for unknown reason.

https://github.com/zephyrproject-rtos/hal_atmel/blob/5a44c9d54dffd685fb6664a646922cfe41c5cf8e/asf/sam/include/samv71/component/usbhs.h#L1299-L1325

https://github.com/zephyrproject-rtos/hal_atmel/blob/5a44c9d54dffd685fb6664a646922cfe41c5cf8e/asf/sam/include/samv71b/component/usbhs.h#L1341-L1355

https://gist.github.com/stephanosio/cc7dd2049a740bdb13b1acdf6c6325af

ADD: These definitions have also been removed in the latest SAME70 DFP 2.4.166 SAME70B usbhs.h header. Need to investigate ... => it looks like they decided to define the register bits per mode in the latest DFP. For instance, USBHS_DEVEPTISR_RXSTPI is now USBHS_DEVEPTISR_CTRL_RXSTPI.

UPDATE: I will provide a fix for this tomorrow on top of #23055 in this PR.

stephanosio · 2020-03-28T12:55:27Z

Rebased

nandojve · 2020-03-28T14:41:19Z

Tested on SAMV71 with samples/net/telnet using net->ping and net->dns.

dts/bindings/ethernet/atmel,sam-gmac.yaml

drivers/ethernet/eth_sam_gmac_priv.h

drivers/ethernet/eth_sam_gmac.c

galak

If you want to pull out the commits for creating the 'B' variants that PR could get merged while the GMAC changes are still being done.

Please convert to use the new DT macro's in include/devicetree.h.

This commit adds the missing Atmel SAM-family GMAC Ethernet device binding. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit updates the Atmel SAM GMAC driver to use the device tree values for GMAC hardware configuration. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit adds a GMAC instance to the SAM E70 device tree, with the chip revision-specific hardware queue count. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit adds a new `sam_e70b_xplained` variant with the chip revision B device tree. In addition, this commit enables the newly added GMAC device tree instance. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit adds a GMAC instance to the SAM V71 device tree, with the chip revision-specific hardware queue count. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit adds a new `sam_v71_xult` variant with the chip revision B device tree. In addition, this commit enables the newly added GMAC device tree instance. Signed-off-by: Stephanos Ioannidis <[email protected]>

This commit removes the Kconfig MAC address configurations for the `sam_e70_xplained` board, as these have been migrated to use the device tree configurations. Signed-off-by: Stephanos Ioannidis <[email protected]>

mnkp

LGTM, comments from @galak still need to be addressed.

stephanosio · 2020-03-28T18:23:33Z

If you want to pull out the commits for creating the 'B' variants that PR could get merged while the GMAC changes are still being done.

Please convert to use the new DT macro's in include/devicetree.h.

@galak I have added a new commit to convert the Atmel SAM GMAC driver to use the new DT_INST macros.

drivers/ethernet/eth_sam_gmac_priv.h

galak

in general looks good, one change associated with where the #define DT_DRV_COMPAT is done.

This commit converts the Atmel SAM GMAC driver to use the new DT_INST macro APIs. Signed-off-by: Stephanos Ioannidis <[email protected]>

stephanosio · 2020-03-29T01:14:10Z

in general looks good, one change associated with where the #define DT_DRV_COMPAT is done.

@galak Fixed

stephanosio added area: Drivers area: Devicetree platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: Ethernet area: Devicetree Binding PR modifies or adds a Device Tree binding labels Feb 24, 2020

stephanosio requested review from galak, jukkar, MaureenHelm, pfalcon and tbursztyka as code owners February 24, 2020 07:03

stephanosio requested review from aurel32 and mnkp February 24, 2020 07:04

zephyrbot added the area: Boards label Feb 24, 2020

pfalcon reviewed Feb 24, 2020

View reviewed changes

stephanosio requested a review from ulfalizer February 24, 2020 07:24

stephanosio force-pushed the add_gmac_dts branch from 4fad275 to 0851259 Compare February 24, 2020 07:45

nandojve mentioned this pull request Feb 24, 2020

Fix and enable sam4e ethernet port #23031

Merged

stephanosio added this to the v2.3.0 milestone Feb 24, 2020

stephanosio added the DNM This PR should not be merged (Do Not Merge) label Feb 24, 2020

stephanosio mentioned this pull request Feb 25, 2020

drivers: ethernet: eth_sam_gmac: Fix priority queues #22961

Merged

stephanosio force-pushed the add_gmac_dts branch from 0851259 to e62b4d4 Compare February 25, 2020 06:00

stephanosio requested review from finikorg and jfischer-no as code owners February 25, 2020 06:00

zephyrbot added the area: Modules label Feb 25, 2020

stephanosio force-pushed the add_gmac_dts branch from e62b4d4 to ac223b5 Compare February 25, 2020 16:53

nandojve approved these changes Mar 28, 2020

View reviewed changes

stephanosio closed this Mar 28, 2020

stephanosio reopened this Mar 28, 2020

galak reviewed Mar 28, 2020

View reviewed changes

dts/bindings/ethernet/atmel,sam-gmac.yaml Outdated Show resolved Hide resolved

galak reviewed Mar 28, 2020

View reviewed changes

dts/bindings/ethernet/atmel,sam-gmac.yaml Show resolved Hide resolved

galak reviewed Mar 28, 2020

View reviewed changes

drivers/ethernet/eth_sam_gmac_priv.h Outdated Show resolved Hide resolved

galak reviewed Mar 28, 2020

View reviewed changes

drivers/ethernet/eth_sam_gmac.c Show resolved Hide resolved

galak requested changes Mar 28, 2020

View reviewed changes

stephanosio added 7 commits March 29, 2020 02:47

dts: bindings: Add Atmel SAM-family GMAC binding

5cf00c4

This commit adds the missing Atmel SAM-family GMAC Ethernet device binding. Signed-off-by: Stephanos Ioannidis <[email protected]>

drivers: ethernet: sam_gmac: Use device tree values

b6b1257

This commit updates the Atmel SAM GMAC driver to use the device tree values for GMAC hardware configuration. Signed-off-by: Stephanos Ioannidis <[email protected]>

dts: arm: atmel: Add SAM E70 GMAC instance

ff07c7c

This commit adds a GMAC instance to the SAM E70 device tree, with the chip revision-specific hardware queue count. Signed-off-by: Stephanos Ioannidis <[email protected]>

boards: sam_e70_xplained: Add revision B variant

7d80f86

This commit adds a new `sam_e70b_xplained` variant with the chip revision B device tree. In addition, this commit enables the newly added GMAC device tree instance. Signed-off-by: Stephanos Ioannidis <[email protected]>

dts: arm: atmel: Add SAM V71 GMAC instance

2dad35a

This commit adds a GMAC instance to the SAM V71 device tree, with the chip revision-specific hardware queue count. Signed-off-by: Stephanos Ioannidis <[email protected]>

boards: sam_v71_xult: Add revision B variant

1f49619

This commit adds a new `sam_v71_xult` variant with the chip revision B device tree. In addition, this commit enables the newly added GMAC device tree instance. Signed-off-by: Stephanos Ioannidis <[email protected]>

samples: net: gptp: Remove Kconfig MAC address for sam_e70_xplained

c2b1217

This commit removes the Kconfig MAC address configurations for the `sam_e70_xplained` board, as these have been migrated to use the device tree configurations. Signed-off-by: Stephanos Ioannidis <[email protected]>

mnkp approved these changes Mar 28, 2020

View reviewed changes

stephanosio force-pushed the add_gmac_dts branch from 57ffebc to ea01adf Compare March 28, 2020 18:22

stephanosio requested a review from galak March 28, 2020 18:23

galak reviewed Mar 28, 2020

View reviewed changes

drivers/ethernet/eth_sam_gmac_priv.h Outdated Show resolved Hide resolved

galak reviewed Mar 28, 2020

View reviewed changes

drivers: ethernet: sam_gmac: Convert to new DT_INST macros

45e3aac

This commit converts the Atmel SAM GMAC driver to use the new DT_INST macro APIs. Signed-off-by: Stephanos Ioannidis <[email protected]>

stephanosio force-pushed the add_gmac_dts branch from ea01adf to 45e3aac Compare March 28, 2020 18:35

stephanosio requested a review from galak March 28, 2020 18:38

galak approved these changes Mar 31, 2020

View reviewed changes

galak merged commit 57c28c0 into zephyrproject-rtos:master Mar 31, 2020

stephanosio deleted the add_gmac_dts branch April 23, 2020 06:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GMAC device tree binding #23045

Add GMAC device tree binding #23045

stephanosio commented Feb 24, 2020 •

edited

Loading

stephanosio commented Feb 24, 2020

zephyrbot commented Feb 24, 2020 •

edited

Loading

pfalcon left a comment

stephanosio commented Feb 24, 2020

stephanosio commented Feb 24, 2020

stephanosio commented Feb 24, 2020 •

edited

Loading

stephanosio commented Mar 28, 2020

nandojve commented Mar 28, 2020

galak left a comment

mnkp left a comment

stephanosio commented Mar 28, 2020

galak left a comment

stephanosio commented Mar 29, 2020

Add GMAC device tree binding #23045

Add GMAC device tree binding #23045

Conversation

stephanosio commented Feb 24, 2020 • edited Loading

stephanosio commented Feb 24, 2020

zephyrbot commented Feb 24, 2020 • edited Loading

checkpatch (informational only, not a failure)

pfalcon left a comment

Choose a reason for hiding this comment

stephanosio commented Feb 24, 2020

stephanosio commented Feb 24, 2020

stephanosio commented Feb 24, 2020 • edited Loading

stephanosio commented Mar 28, 2020

nandojve commented Mar 28, 2020

galak left a comment

Choose a reason for hiding this comment

mnkp left a comment

Choose a reason for hiding this comment

stephanosio commented Mar 28, 2020

galak left a comment

Choose a reason for hiding this comment

stephanosio commented Mar 29, 2020

stephanosio commented Feb 24, 2020 •

edited

Loading

zephyrbot commented Feb 24, 2020 •

edited

Loading

stephanosio commented Feb 24, 2020 •

edited

Loading