-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert SAM drivers to DT_INST #22806
Conversation
Moved the commits related to SAM into one PR, so easier to get review that way. |
TODO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I believe it is too early to convert all remaining SAM drivers to DT_INST. This family requires pinctrl data to be provided by DTS. For now we could convert watchdog, as this PR proposes, GPIO and counter. Any driver that doesn't require pinctlr.
Convert driver to use DT_INST_ defines. Signed-off-by: Kumar Gala <[email protected]>
Convert driver to use DT_INST_ defines. The preferred defines for drivers are DT_INST_. Signed-off-by: Kumar Gala <[email protected]>
Going to handle this with a mix of DT_INST and DT_NODELABEL. Once NODELABEL is in place I'll work up a PR to show the mix of pinctrl + driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done full review before, I was under impression that more drivers will be added to this PR. The two commits converting watchdog and entropy drivers look good.
I was thinking its best to merge and close out the PRs for the easy stuff and than have follow on PRs. Was thinking this was going to go faster, and thus the previous model that you are thinking about. |
No description provided.