flashing: do not give bossac the offset parameter if not explicitly provided. #22179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
KubaFYI
force-pushed
the
fix_bossac_runner_parameter_#22171
branch
from
c2e5093
to
4aee4e5
Compare
KubaFYI
changed the title
|
For future reference, please force-push into your existing branches instead of closing a pull request and opening a new one. Closing PRs makes it harder for reviewers to track comments and their resolution. See the zephyr contribution guidelines for more details. |
mbolivar
approved these changes
Jan 27, 2020
| '-b', self.cfg.bin_file] | ||
| if self.offset is not None: | ||
| cmd_flash = cmd_flash + ['-o', '%s' % self.offset] |
There was a problem hiding this comment.
Minor nit, an in-place update would be slightly preferable style-wise:
Suggested change
| cmd_flash = cmd_flash + ['-o', '%s' % self.offset] | |
| cmd_flash += ['-o', '%s' % self.offset] |
|
@KubaFYI please take a look at the shippable error and make sure the tests are passing. See the README in the west_commands directory for info on running tests. |
This fixes a problem which appeared after bossac version was downgraded to 1.7 which no longer accepts the -o/--offset parameter. Now the offset is fed to bossac executable only if it's explicitly provided and not by default. Signed-off-by: Kuba Sanak <[email protected]>
KubaFYI
force-pushed
the
fix_bossac_runner_parameter_#22171
branch
from
4aee4e5
to
570540e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't feed bossac the offset parameter unless explicitly requested. This allows the runner to play nicely with earlier versions of bossac.
Fixes: #22171
Signed-off-by: Kuba Sanak [email protected]