Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "scripts: bossac: Support flashing at an offset." #22174

Conversation

KubaFYI
Copy link
Contributor

@KubaFYI KubaFYI commented Jan 24, 2020

This reverts commit bde3224.

Fixes: #22171

Signed-off-by: Kuba Sanak [email protected]

Copy link
Contributor

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galak are you ok with this?

Copy link
Contributor

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 24, 2020

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@galak
Copy link
Collaborator

galak commented Jan 24, 2020

I guess I'd like to see the option left in the running and deal with the case if offset=0 or change / support for offset=None to not pass --offset in that case.

@KubaFYI
Copy link
Contributor Author

KubaFYI commented Jan 24, 2020

Thanks for the feedback @galak . I'll make sure to update the branch to reflect that.

@KubaFYI KubaFYI closed this Jan 24, 2020
@KubaFYI KubaFYI force-pushed the fix_bossac_runner_parameter_#22171 branch from b16aabd to d6d0b64 Compare January 24, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

West bossac runner inorrectly tries to include an offset parameter when flashing
4 participants