Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: sam3x: update Kconfig options after move to SAM SoC family tree #21

Closed
wants to merge 3 commits into from

Conversation

fallrisk
Copy link
Collaborator

@fallrisk fallrisk commented May 1, 2017

The files for the Arduino Due needed to be updated to use the new
configuration when the SoC moved from the atmel_sam3 directory to
the atmel_sam/sam3x directory.

Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617
Origin: Original
Jira: ZEP-2067
Signed-off-by: Justin Watson [email protected]

The files for the Arduino Due needed to be updated to use the new
configuration when the SoC moved from the atmel_sam3 directory to
the atmel_sam/sam3x directory.

Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617
Origin: Original
Jira: ZEP-2067
Signed-off-by: Justin Watson <[email protected]>
Copy link
Member

@mnkp mnkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • arch/arm/soc/atmel_sam/sam3x/Kconfig.soc contains references to SOC_ATMEL_SAM3_EXT_MAINCK, should be SOC_ATMEL_SAM3X_EXT_MAINCK
  • in arch/arm/soc/atmel_sam/sam3x/soc.c strings SOC_ATMEL_SAM3_EXT_ should be changed to SOC_ATMEL_SAM3X_EXT_
  • Sorry for my misleading comment in Gerrit. All occurrences of SOC_ATMEL_SAM3 should have been changed to SOC_SERIES_SAM3X, not SOC_SERIES_SAM3 as I stated. This needs to be corrected.

@mnkp
Copy link
Member

mnkp commented May 1, 2017

When committing to Gerrit the policy was to have full first and surname in the Author field of the commit header. This may still be the case.

The "Origin: Original" line in git commit message is only required for the initial commit of a new module/library.

The files for the Arduino Due needed to be updated to use the new
configuration when the SoC moved from the atmel_sam3 directory to
the atmel_sam/sam3x directory.

Change-Id: I744a490ffb574cb29e5a4b74484c15ca6dd30617
Origin: Original
Jira: ZEP-2067
Signed-off-by: Justin Watson <[email protected]>
@fallrisk
Copy link
Collaborator Author

fallrisk commented May 1, 2017

Closing this pull request and opening to a new pull request in the arm branch.

@fallrisk fallrisk closed this May 1, 2017
@fallrisk fallrisk deleted the arduino_due branch May 1, 2017 21:32
NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022
…ack (zephyrproject-rtos#21)

Modifies the BLE stack to call a newly added callback whenever MFI audio comes in
henrikbrixandersen pushed a commit to vestas-wind-systems/zephyr that referenced this pull request Jan 5, 2023
…sai_edma

Support for multichannel SAI EDMA transfers
LukaszMrugala pushed a commit to LukaszMrugala/zephyr that referenced this pull request Jul 3, 2024
- Add pr_comment.py script which spoots out the tag info for both the
zephyr and zephyr-intel repos to be pasted into the respective PRs.

- Remove a duplicate line from the tag_manifest.py script.

- Use rebase branch name to get date stamp
It's preferable for the tag datestamp to match the branch datestamp to
help avoid confusion in the PR. i.e. Tag date doesn't match branch date
= confusing. So make 'em match. Extract the datestamp from the branch
 name.

In the event the branch is created the same day as tagging happens, can
just run without passing the branch.

Generally should not run the tagging before the branch is created, to
avoid mismatched branch and tag date mismatch.

Signed-off-by: Connor Graydon <[email protected]>

Signed-off-by: Connor Graydon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants