scripts: edtlib: Forbid multiple bindings with the same compatible + Node.description nit #19806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfalizer
force-pushed
the
duplicate-compatible
branch
from
ab59aae to
cd6865e
Compare
Simplifies the code a bit. Looks like the description wasn't rstrip()ed when it came from a 'child-binding:' either. This also indirectly fixes that. Signed-off-by: Ulf Magnusson <[email protected]>
Previously, if two bindings had the same 'compatible:'/'parent-bus:' values, the binding that happened to be loaded last would get used. Turn it into an error instead. This avoids tricking people into thinking that bindings get loaded in a defined order. Maybe overriding bindings could be allowed later, if we need it. Fixes: zephyrproject-rtos#19536 Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
force-pushed
the
duplicate-compatible
branch
from
cd6865e to
618b38f
Compare
pabigot
approved these changes
Oct 14, 2019
carlescufi
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One new binding-related error (to fix #19536) and an unrelated cleanup: