make compilation with xcc work again (fix issue #17095) #17267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2019 16:19
Commit f57ba2d ("cmake: toolchain_cc_imacros: don't use space separated arguments") moved toolchain_cc_imacros() to using the long argument format in order to avoid spaces that CMake uses to delimitate and deduplicate arguments. It seems that xcc doesn't support the --imacros=foo form. However it does support the short "combined" -imacrosfoo form (without space). So let's use that instead and document the caviat. Signed-off-by: Nicolas Pitre <[email protected]>
The zephyr_stdint.h file enforces Zephyr specific policies on the compilation environment. Let's give compilers a chance to provide definitions of their own via TOOLCHAIN_C_FLAGS prior the inclusion of zephyr_stdint.h. Signed-off-by: Nicolas Pitre <[email protected]>
Ensure that xcc is at parity with gcc and clang by inferring missing definitions based on those that it already provides. Signed-off-by: Nicolas Pitre <[email protected]>
npitre
requested review from
andrewboie,
andyross,
nashif and
SebastianBoe
as code owners
jhedberg
approved these changes
Jul 3, 2019
jhedberg
added
area: Xtensa
ioannisg
added
the
Hotfix
nashif
approved these changes
Jul 3, 2019
|
Thanks @tejlmand for mentioning in PR #24851 this CMake 3.12 anti-deduplication feature:
(I never understood this "benefice" BTW) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17095