tests: minor FCB re-ordering not to leave a random flash.bin behind #16965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last FCB test to run (fcb_test_last_of_n) uses uninitialized test_data[] and leaves behind a flash.bin with random content. Pick another one (fcb_test_reset) that leaves a deterministic flash.bin behind and run that last instead. Signed-off-by: Marc Herbert <[email protected]>
zephyrbot
added
the
area: Tests
|
The Shippable failures happened all in different, totally unrelated scheduler tests: |
nashif
approved these changes
Jun 21, 2019
nvlsianpu
approved these changes
Jun 21, 2019
carlescufi
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last FCB test to run (fcb_test_last_of_n) uses uninitialized
test_data[] and leaves behind a flash.bin with random content. Pick
another one (fcb_test_reset) that leaves a deterministic flash.bin
behind and run that last instead.
Signed-off-by: Marc Herbert [email protected]