USB: Fix console priority #16613
Merged
USB: Fix console priority #16613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does make sense to initialize USB console after USB Device stack. Note that the value is selected only if we specify USB_UART_CONSOLE in prj.conf, not in menuconfig afterwards. Fixes zephyrproject-rtos#16518 Signed-off-by: Andrei Emeltchenko <[email protected]>
Trivial function name fix. Signed-off-by: Andrei Emeltchenko <[email protected]>
carlescufi
approved these changes
Jun 4, 2019
|
I steel see it as a workaround not as fix. It does not change behavior of uart_console_init, it will block until usb device was attached and initialized. I think we can merge it, but I suggest not to close #16518 with this PR. |
carlescufi
approved these changes
Jun 5, 2019
jfischer-no
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16518