Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc: arm: fix support for MPUs on non-XIP systems #15656

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

andrewboie
Copy link
Contributor

@andrewboie andrewboie commented Apr 24, 2019

We now use MPU_ALIGN() to set the location counter after the ROM region.
On non-power of two systems, this just rounds the location up to the MPU granularity, the parameter value is ignored.
On power of two systems, this rounds up appropriately based on the size of ROM.

Fixes: #15558

Signed-off-by: Andrew Boie [email protected]

@zephyrbot
Copy link
Collaborator

zephyrbot commented Apr 24, 2019

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

include/toolchain/gcc.h Outdated Show resolved Hide resolved
arch/Kconfig Outdated Show resolved Hide resolved
include/arch/arc/arch.h Outdated Show resolved Hide resolved
@ruuddw ruuddw requested review from vonhust and ruuddw April 25, 2019 14:39
@andrewboie
Copy link
Contributor Author

I found a much simpler way to do this entirely in the linker script.

I'll take off 'draft' status once I've done some more testing.

@andrewboie andrewboie marked this pull request as ready for review April 25, 2019 16:57
@andrewboie
Copy link
Contributor Author

recheck

The size of the ROM region is now rounded up to the
nearest power of two; we no longer assume that RAM
is in a different part of memory.

Fixes: zephyrproject-rtos#15558

Signed-off-by: Andrew Boie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for power-of-two MPUs on non-XIP systems
6 participants