-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arc: arm: fix support for MPUs on non-XIP systems #15656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All checks are passing now. Review history of this comment for details about previous failed status. |
andrewboie
force-pushed
the
mpu-xip-systems
branch
from
April 24, 2019 18:14
2310381
to
303280f
Compare
ulfalizer
reviewed
Apr 24, 2019
ruuddw
reviewed
Apr 25, 2019
andrewboie
force-pushed
the
mpu-xip-systems
branch
from
April 25, 2019 16:44
303280f
to
3707e32
Compare
I found a much simpler way to do this entirely in the linker script. I'll take off 'draft' status once I've done some more testing. |
andrewboie
force-pushed
the
mpu-xip-systems
branch
from
April 25, 2019 16:57
3707e32
to
be0d10c
Compare
andrewboie
requested review from
ulfalizer,
agross-oss,
andyross,
dcpleung and
nashif
April 25, 2019 16:57
dcpleung
approved these changes
Apr 25, 2019
andrewboie
force-pushed
the
mpu-xip-systems
branch
from
April 25, 2019 18:01
be0d10c
to
d12468e
Compare
recheck |
The size of the ROM region is now rounded up to the nearest power of two; we no longer assume that RAM is in a different part of memory. Fixes: zephyrproject-rtos#15558 Signed-off-by: Andrew Boie <[email protected]>
andrewboie
force-pushed
the
mpu-xip-systems
branch
from
April 25, 2019 20:25
d12468e
to
0dbe736
Compare
nashif
approved these changes
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use MPU_ALIGN() to set the location counter after the ROM region.
On non-power of two systems, this just rounds the location up to the MPU granularity, the parameter value is ignored.
On power of two systems, this rounds up appropriately based on the size of ROM.
Fixes: #15558
Signed-off-by: Andrew Boie [email protected]