Decouple system timer and drivers: SoC Initialization #15505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizi-nordic
requested review from
andrewboie,
andyross,
fallrisk,
galak,
MaureenHelm,
rgundi and
vanti
as code owners
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-soc
branch
from
1e00cbe
to
72030f8
Compare
ioannisg
reviewed
Apr 17, 2019
| @@ -44,6 +44,7 @@ | |||
|
|
|||
| #include <stdint.h> | |||
| #include <ti/devices/msp432p4xx/inc/msp.h> | |||
| #include <generated_dts_board.h> | |||
There was a problem hiding this comment.
I am not so happy with including generated headers in ext.
Could this be done in soc.h, instead?
ioannisg
approved these changes
Apr 17, 2019
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-soc
branch
from
72030f8
to
4964110
Compare
andrewboie
reviewed
Apr 26, 2019
|
@andrewboie: The CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC is still set manually in defconfig. However all these changes are preparation for removal of of this define. I noticed, that it is widely used in wrong context as well as in many places we are assuming that system clock frequency is known at compile time which is not always true. |
|
All checks are passing now. Review history of this comment for details about previous failed status. |
This patch adds generation of DT_ macros for values assigned to the `clock-frequency` property in `/cpus/cpu*` nodes. Signed-off-by: Andrzej Głąbek <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The SoC initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The clock control initialization code used system clock frequency as a CPU clock frequency. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The log_backend_swo used system clock frequency as a base for SWO clock calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-soc
branch
from
ba9f81a
to
d11b92d
Compare
anangl
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our work in timer area, we found that system clock frequency is used incorrectly in several places.
For example, it is used to obtain CPU frequency needed for SoC initialization.
If we select different system timer device, all these calculations become invalid.
This PR fixes the problem by obtaining all needed information directly from the DTS.
Brings us closer to: #15363