tests: kernel: App to validate boot time page table #1286

akhileshupadhyay · 2017-08-29T11:35:47Z

Testcase developed to validate boot time page table faults.

Signed-off-by: Akhilesh Kumar Upadhyay [email protected]

galak

This seems like a pretty x86 specific test, can we rename so its clear that its x86 specific.

nashif

Can you please add a README explaining what is being tested here and give more details?

nashif · 2017-08-29T15:36:02Z

tests/kernel/boot_page_table/src/main.c

@@ -0,0 +1,13 @@
+#include <ztest.h>


missing copyright/license header

nashif · 2017-08-29T15:36:06Z

tests/kernel/boot_page_table/src/boot_page_table.h

@@ -0,0 +1,28 @@
+#ifndef X86_MMU_GET_PT_ADDR


missing copyright/license header

you also need a header guard here

nashif · 2017-08-29T15:36:12Z

tests/kernel/boot_page_table/src/boot_page_table.c

@@ -0,0 +1,110 @@
+#include <zephyr.h>


missing copyright/license header

akhileshupadhyay · 2017-09-04T11:10:20Z

Missing copyright/license header is added to the necessary files. README file is added with details. The header guards are also added.

AdithyaBaglody · 2017-09-04T12:15:14Z

tests/kernel/boot_page_table/src/boot_page_table.h

+#define STARTING_ADDR_RANGE_LMT   0x0009ff
+#define START_ADR_RANGE_OVRLP_LMT 0x001000
+#define REGION_PERM                (MMU_READ_WRITE | MMU_PAGE_USER)
+#endif


move line 37 (#endif )to line 27

#endif moved to line 27

AdithyaBaglody · 2017-09-04T12:18:32Z

tests/kernel/boot_page_table/src/boot_page_table.c

+#include <ztest.h>
+#include "boot_page_table.h"
+
+MMU_BOOT_REGION(START_ADDR_RANGE, ADDR_SIZE, REGION_PERM);


add multiple regions into the test. as of now it is testing a single memory region.
Create multiple memory regions and validate them with the below APIs.

multiple memory regions has been created and added to validate upon.

AdithyaBaglody · 2017-11-03T10:18:56Z

tests/kernel/boot_page_table/src/boot_page_table.c

+	zassert_true(ending_start_addr_range() == TC_PASS, NULL);
+}
+
+void test_starting_addr_range1(void)


Pass arguments into the same function. if arguments== 1 then take start addr 1 if argument == 2 then take start addr2 so on.
Don't duplicate the code.

@AdithyaBaglody . The memory address are already passed based on the arguments.

…ct-rtos#1286) This includes base configuration common to all platforms. Fixes zephyrproject-rtos#1260. Signed-off-by: Geoff Gustafson <[email protected]>

akhileshupadhyay · 2017-11-28T05:51:15Z

@galak Could you please review the changes requested by you.

kumarvikash1

copyright/license header, header guard and line breaking has been addressed. Approved.

kumarvikash1 · 2017-11-30T07:00:52Z

@SebastianBoe @galak : Can you please review the changes. This PR is planned for R-1.10.

SebastianBoe · 2017-11-30T10:59:27Z

I am not able to review, removed myself from reviewers list.

galak · 2017-11-30T20:26:51Z

My comment about renaming since this is x86 specific is still valid.

akhileshupadhyay · 2017-12-01T04:35:18Z

@galak . Could you please check, the renaming is done for x86.

galak · 2017-12-01T14:46:41Z

tests/kernel/x86boot_page_table/testcase.yaml

@@ -0,0 +1,4 @@
+tests:
+-   test:
+        platform_whitelist: qemu_x86


Is there any reason this test will not run on any x86 platform?

Seems like we should have:

arch_whitelist: x86

for sure in here.

akhileshupadhyay · 2017-12-01T15:28:54Z

@galak . The changes have been addressed for arch_whitelist: x86

Changes made that I asked for

galak · 2017-12-01T15:38:21Z

@akhileshupadhyay thanks. I removed my 'requests changes'. I leave this up to @nashif to decide if he's ok with it and wants it merged in 1.10.

nashif

remove x86 from the path name x86boot_page_table/...

Testcase developed to validate x86 specific boot time page table faults. Signed-off-by: Akhilesh Kumar Upadhyay <[email protected]>

akhileshupadhyay · 2017-12-04T18:31:19Z

@nashif Could please check, removed x86 from x86boot_page_table path name.

galak previously requested changes Aug 29, 2017

View reviewed changes

andrewboie requested a review from AdithyaBaglody August 29, 2017 15:02

nashif requested changes Aug 29, 2017

View reviewed changes

akhileshupadhyay force-pushed the bootpagetable branch from ff1eab5 to bb0cb51 Compare September 4, 2017 10:25

AdithyaBaglody suggested changes Sep 4, 2017

View reviewed changes

akhileshupadhyay force-pushed the bootpagetable branch 3 times, most recently from 02e4f9c to d69c2bc Compare September 5, 2017 13:18

AdithyaBaglody suggested changes Nov 3, 2017

View reviewed changes

akhileshupadhyay force-pushed the bootpagetable branch from d69c2bc to 5952bf6 Compare November 19, 2017 20:04

akhileshupadhyay requested a review from SebastianBoe as a code owner November 19, 2017 20:04

akhileshupadhyay force-pushed the bootpagetable branch 7 times, most recently from 5899ded to 85e5da1 Compare November 27, 2017 08:13

AdithyaBaglody approved these changes Nov 27, 2017

View reviewed changes

kumarvikash1 approved these changes Nov 29, 2017

View reviewed changes

kumarvikash1 assigned SebastianBoe Nov 30, 2017

kumarvikash1 added this to the v1.10.0 milestone Nov 30, 2017

SebastianBoe removed their request for review November 30, 2017 10:57

SebastianBoe removed their assignment Nov 30, 2017

akhileshupadhyay force-pushed the bootpagetable branch from 85e5da1 to 3745262 Compare December 1, 2017 04:19

akhileshupadhyay force-pushed the bootpagetable branch from 3745262 to 88ec235 Compare December 1, 2017 04:44

galak reviewed Dec 1, 2017

View reviewed changes

akhileshupadhyay force-pushed the bootpagetable branch from 88ec235 to f90caf6 Compare December 1, 2017 15:25

akhileshupadhyay force-pushed the bootpagetable branch 2 times, most recently from 3e73924 to 761e7b0 Compare December 4, 2017 06:35

nashif requested changes Dec 4, 2017

View reviewed changes

tests: kernel: x86 : App to validate x86 specific boot time page table

eec3a3f

Testcase developed to validate x86 specific boot time page table faults. Signed-off-by: Akhilesh Kumar Upadhyay <[email protected]>

akhileshupadhyay force-pushed the bootpagetable branch from 761e7b0 to eec3a3f Compare December 4, 2017 18:10

nashif approved these changes Dec 5, 2017

View reviewed changes

nashif merged commit 149c341 into zephyrproject-rtos:master Dec 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: kernel: App to validate boot time page table #1286

tests: kernel: App to validate boot time page table #1286

akhileshupadhyay commented Aug 29, 2017

galak left a comment

nashif left a comment

nashif Aug 29, 2017

nashif Aug 29, 2017

nashif Aug 29, 2017

nashif Aug 29, 2017

akhileshupadhyay commented Sep 4, 2017

AdithyaBaglody Sep 4, 2017

akhileshupadhyay Sep 5, 2017

AdithyaBaglody Sep 4, 2017

akhileshupadhyay Sep 5, 2017

AdithyaBaglody Nov 3, 2017

akhileshupadhyay Nov 27, 2017

akhileshupadhyay commented Nov 28, 2017

kumarvikash1 left a comment

kumarvikash1 commented Nov 30, 2017

SebastianBoe commented Nov 30, 2017

galak commented Nov 30, 2017

akhileshupadhyay commented Dec 1, 2017

galak Dec 1, 2017

akhileshupadhyay commented Dec 1, 2017

galak commented Dec 1, 2017

nashif left a comment

akhileshupadhyay commented Dec 4, 2017

tests: kernel: App to validate boot time page table #1286

tests: kernel: App to validate boot time page table #1286

Conversation

akhileshupadhyay commented Aug 29, 2017

galak left a comment

Choose a reason for hiding this comment

nashif left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akhileshupadhyay commented Sep 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akhileshupadhyay commented Nov 28, 2017

kumarvikash1 left a comment

Choose a reason for hiding this comment

kumarvikash1 commented Nov 30, 2017

SebastianBoe commented Nov 30, 2017

galak commented Nov 30, 2017

akhileshupadhyay commented Dec 1, 2017

Choose a reason for hiding this comment

akhileshupadhyay commented Dec 1, 2017

galak commented Dec 1, 2017

nashif left a comment

Choose a reason for hiding this comment

akhileshupadhyay commented Dec 4, 2017