-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dummy display driver #12223
Added dummy display driver #12223
Conversation
Added dummy display driver. fixes: zephyrproject-rtos#12001 Signed-off-by: Jan Van Winkel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12223 +/- ##
=======================================
Coverage 48.3% 48.3%
=======================================
Files 293 293
Lines 44136 44136
Branches 10591 10591
=======================================
Hits 21318 21318
Misses 18552 18552
Partials 4266 4266 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, it seems fine, but I'm no display API expert.
Sidetrack: It seems a bit inconvenient that, to change the display driver that is initialized one needs to change the application. E.g.: diff --git a/samples/display/cfb/src/main.c b/samples/display/cfb/src/main.c
index c4e74cbd27..a36b0b0d10 100644
--- a/samples/display/cfb/src/main.c
+++ b/samples/display/cfb/src/main.c
@@ -17,6 +17,10 @@
#define DISPLAY_DRIVER "SSD1306"
#endif
+#if defined (CONFIG_DUMMY_DISPLAY)
+#define DISPLAY_DRIVER "DUMMY_DISPLAY"
+#endif
+
#ifndef DISPLAY_DRIVER
#define DISPLAY_DRIVER "DISPLAY"
#endif |
@aescolar Thx for the review! On the sidetrack:
There is not need to change the code if overlay-dummy-display.conf
Cmake cmd:
|
( Yes.. and one could also have set the |
The only reason I can come up with is that if you would have multiple displays you could get a name clash if they all default to "DISPLAY" |
Added dummy display driver
This driver can be used in CI together with a native posix target
fixes: #12001