Bluetooth: controller: Fix conn update assert in slave role #11764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly track the connection update related ticker stop and start to avoid asserting due to ticker update being done at the same time for compensating the clock drift. The compensation related ticker update failure in this case can be safely ignored as new anchor point is used anyway at the instant of the connection update. Fixes zephyrproject-rtos#8796 Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
carlescufi
approved these changes
Nov 30, 2018
|
recheck |
Codecov Report
@@ Coverage Diff @@
## master #11764 +/- ##
==========================================
+ Coverage 48.2% 48.26% +0.05%
==========================================
Files 280 280
Lines 43323 43328 +5
Branches 10374 10373 -1
==========================================
+ Hits 20886 20913 +27
+ Misses 18289 18265 -24
- Partials 4148 4150 +2
Continue to review full report at Codecov.
|
cvinayak
added a commit
to cvinayak/zephyr
that referenced
this pull request
Jun 5, 2019
Explicitly track the connection update related ticker stop and start to avoid asserting due to ticker update being done at the same time for compensating the master clock drift. Relates to zephyrproject-rtos#11764. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
aescolar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Explicitly track the connection update related ticker stop and start to avoid asserting due to ticker update being done at the same time for compensating the master clock drift. Relates to #11764. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly track the connection update related ticker stop
and start to avoid asserting due to ticker update being done
at the same time for compensating the clock drift.
The compensation related ticker update failure in this case
can be safely ignored as new anchor point is used anyway
at the instant of the connection update.
Fixes #8796
Signed-off-by: Vinayak Kariappa Chettimada [email protected]